Skip to content

[ROCm][Quantization] Enable moe_wna16 on ROCm via Triton fallback #35596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brucechanglongxu wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

[ROCm][Quantization] Enable moe_wna16 on ROCm via Triton fallback #35596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vllm/model_executor/layers/fused_moe/fused_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,6 +1217,7 @@ def should_moe_wna16_use_cuda(
):
return (
current_platform.is_cuda()
and not current_platform.is_rocm()
Comment on lines 1219 to +1220
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

To make the platform check more direct and robust against potential inconsistencies in is_cuda() behavior across environments, consider using current_platform.device_name == 'cuda'. This directly checks for the CUDA platform and is less prone to misinterpretation.

Suggested change
current_platform.is_cuda()
and not current_platform.is_rocm()
current_platform.device_name == "cuda"

and bit == 4
and group_size in [32, 64, 128]
and num_valid_tokens / num_experts <= 6
Expand Down
1 change: 1 addition & 0 deletions vllm/platforms/rocm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ class RocmPlatform(Platform):
"petit_nvfp4",
"torchao",
"bitsandbytes",
"moe_wna16",
]

@classmethod
Expand Down