Skip to content

[Bugfix] Fix AllReduceFusionPass crash with PP+TP configurations #35468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haosdent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Bugfix] Fix AllReduceFusionPass crash with PP+TP configurations #35468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions vllm/compilation/passes/fusion/allreduce_rms_fusion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,22 @@ def __init__(self, config: VllmConfig) -> None:
if self.tp_size <= 1:
logger.warning_once("AllReduce fusion pass is disabled for tp_size <= 1.")
return
if config.parallel_config.pipeline_parallel_size > 1:
# flashinfer has issues with multi-group TP configurations.
# See: https://github.com/flashinfer-ai/flashinfer/issues/2647
logger.warning_once(
"AllReduce fusion pass is disabled for PP+TP due to "
"a flashinfer device assignment limitation."
)
return
if config.parallel_config.data_parallel_size > 1:
# flashinfer has issues with multi-group TP configurations.
# See: https://github.com/flashinfer-ai/flashinfer/issues/2647
logger.warning_once(
"AllReduce fusion pass is disabled for DP+TP due to "
"a flashinfer device assignment limitation."
)
return
self.patterns: PatternMatcherPass = PatternMatcherPass(
pass_name="all_reduce_fusion_pass"
)
Expand Down