Skip to content

[ROCm][CI] Added MI325 mirrors (stage C) #35239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khluu merged 16 commits into from
Mar 4, 2026
Merged

[ROCm][CI] Added MI325 mirrors (stage C) #35239

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3bb985d
[ROCm][CI] Added MI325 mirrors
AndreasKaratzas Feb 24, 2026
1bc1a45
[ROCm][CI] Added MI325 mirrors
AndreasKaratzas Feb 24, 2026
c0e038e
Updated to correct agent name
AndreasKaratzas Feb 24, 2026
439d4d1
Brought back the 2 GPU MI325 agent for Plugins test
AndreasKaratzas Feb 24, 2026
f2455dc
Merge remote-tracking branch 'origin/main' into akaratza_gating_amdci…
AndreasKaratzas Feb 25, 2026
d3d4ed0
Merge remote-tracking branch 'origin/main' into akaratza_gating_amdci…
AndreasKaratzas Feb 28, 2026
05750df
Merge remote-tracking branch 'origin/main' into akaratza_gating_amdci…
AndreasKaratzas Mar 1, 2026
a59425f
Merge remote-tracking branch 'origin/main' into akaratza_gating_amdci…
AndreasKaratzas Mar 3, 2026
d7939a1
Merge remote-tracking branch 'origin/main' into akaratza_gating_amdci…
AndreasKaratzas Mar 3, 2026
dfb8207
Removed language model standard test group AMD mirror for now
AndreasKaratzas Mar 3, 2026
b6a5ea7
Merge remote-tracking branch 'origin/main' into akaratza_gating_amdci…
AndreasKaratzas Mar 4, 2026
0fd15b1
Merge remote-tracking branch 'origin/main' into akaratza_gating_amdci…
AndreasKaratzas Mar 4, 2026
3eefd34
Refactored gating test list
AndreasKaratzas Mar 4, 2026
10094ce
Merge remote-tracking branch 'origin/main' into akaratza_gating_amdci…
AndreasKaratzas Mar 4, 2026
93e4651
[ROCm][CI] finalizing gating test group list
AndreasKaratzas Mar 4, 2026
ff531c3
Merge remote-tracking branch 'origin/main' into akaratza_gating_amdci…
AndreasKaratzas Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .buildkite/test_areas/entrypoints.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ steps:
- export VLLM_WORKER_MULTIPROC_METHOD=spawn
- pytest -v -s entrypoints/openai --ignore=entrypoints/openai/test_chat_with_tool_reasoning.py --ignore=entrypoints/openai/test_oot_registration.py --ignore=entrypoints/openai/test_tensorizer_entrypoint.py --ignore=entrypoints/openai/correctness/ --ignore=entrypoints/openai/tool_parsers/ --ignore=entrypoints/openai/responses
- pytest -v -s entrypoints/test_chat_utils.py
mirror:
amd:
device: mi325_1
depends_on:
- image-build-amd

@gemini-code-assist gemini-code-assist Bot Feb 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This mirror configuration is duplicated for the 'Entrypoints Integration (v1)' step later in this file (lines 90-94). To improve maintainability and reduce redundancy, consider using YAML anchors. This will make future updates to the mirror configuration easier and less error-prone.

For example, you could define an anchor (e.g., at the top of the file, before steps:) and then reference it:

.amd_mi325_1_mirror: &amd_mi325_1_mirror
  mirror:
    amd:
      device: mi325_1
      depends_on:
      - image-build-amd

steps:
  - label: Entrypoints Integration (API Server)
    # ... other properties
    <<: *amd_mi325_1_mirror

  # ... other steps

  - label: Entrypoints Integration (v1)
    # ... other properties
    <<: *amd_mi325_1_mirror


- label: Entrypoints Integration (API Server 2)
timeout_in_minutes: 130
Expand Down Expand Up @@ -82,6 +87,11 @@ steps:
- tests/v1
commands:
- pytest -v -s v1/entrypoints
mirror:
amd:
device: mi325_1
depends_on:
- image-build-amd

- label: OpenAI API Correctness
timeout_in_minutes: 30
Expand Down
5 changes: 5 additions & 0 deletions .buildkite/test_areas/misc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ steps:
- python3 offline_inference/spec_decode.py --test --method eagle --num_spec_tokens 3 --dataset-name hf --dataset-path philschmid/mt-bench --num-prompts 80 --temp 0 --top-p 1.0 --top-k -1 --tp 1 --enable-chunked-prefill --max-model-len 2048
# https://github.com/vllm-project/vllm/pull/26682 uses slightly more memory in PyTorch 2.9+ causing this test to OOM in 1xL4 GPU
- python3 offline_inference/spec_decode.py --test --method eagle3 --num_spec_tokens 3 --dataset-name hf --dataset-path philschmid/mt-bench --num-prompts 80 --temp 0 --top-p 1.0 --top-k -1 --tp 1 --enable-chunked-prefill --max-model-len 1536
mirror:
amd:
device: mi325_1
depends_on:
- image-build-amd
Comment on lines +90 to +94

@gemini-code-assist gemini-code-assist Bot Feb 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This mirror configuration for mi325_1 is identical to configurations added in other files in this PR (e.g., .buildkite/test_areas/entrypoints.yaml, .buildkite/test_areas/models_language.yaml). To centralize configuration and improve maintainability, consider defining this as a reusable YAML anchor in a shared file if your Buildkite pipeline setup supports it. This would prevent potential inconsistencies if the mi325_1 configuration needs to be updated in the future.


- label: Metrics, Tracing (2 GPUs)
timeout_in_minutes: 20
Expand Down
5 changes: 5 additions & 0 deletions .buildkite/test_areas/models_language.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ steps:
# Test standard language models, excluding a subset of slow tests
- pip freeze | grep -E 'torch'
- pytest -v -s models/language -m 'core_model and (not slow_test)'
mirror:
amd:
device: mi325_1
depends_on:
- image-build-amd

- label: Language Models Tests (Extra Standard) %N
timeout_in_minutes: 45
Expand Down
5 changes: 5 additions & 0 deletions .buildkite/test_areas/plugins.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,8 @@ steps:
- pytest -v -s entrypoints/openai/test_oot_registration.py # it needs a clean process
- pytest -v -s models/test_oot_registration.py # it needs a clean process
- pytest -v -s plugins/lora_resolvers # unit tests for in-tree lora resolver plugins
mirror:
amd:
device: mi325_2
depends_on:
- image-build-amd

@AndreasKaratzas AndreasKaratzas Feb 24, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see if I need num_devices: 2 property here as well.

Loading