Skip to content

[ROCm] [Release] Change the package from aiter to amd-aiter#35198

Merged
khluu merged 8 commits intovllm-project:mainfrom
EmbeddedLLM:updatereleasepipeline
Mar 3, 2026
Merged

[ROCm] [Release] Change the package from aiter to amd-aiter#35198
khluu merged 8 commits intovllm-project:mainfrom
EmbeddedLLM:updatereleasepipeline

Conversation

@tjtanaa
Copy link
Copy Markdown
Collaborator

@tjtanaa tjtanaa commented Feb 24, 2026

Purpose

After upgrading the AITER version, AITER library has changed its package name from aiter to amd-aiter. So, we have to update it as well.

Test Plan

Trial run

Test Result

https://buildkite.com/vllm/release-pipeline-shadow/builds/3134/steps/canvas

The generated wheels can be installed using the following command (Python 3.12, ROCm 7.0)

uv pip install --pre vllm==0.16.1rc1.dev99+gd177be305.rocm700 --extra-index-url http://vllm-wheels-dev.s3-website-us-west-2.amazonaws.com/rocm/d177be305da334473234c69d0037d0d1631e82eb/rocm700/ --trusted-host vllm-wheels-dev.s3-website-us-west-2.amazonaws.com --system

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@mergify mergify Bot added ci/build rocm Related to AMD ROCm labels Feb 24, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Feb 24, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the AITER package name from aiter to amd-aiter across the release pipeline and related scripts. The changes involve modifying the .buildkite/release-pipeline.yaml, .buildkite/scripts/annotate-rocm-release.sh, and tools/vllm-rocm/pin_rocm_dependencies.py files to reflect the new package name and ensure consistency in the build and release processes. Additionally, the S3 bucket name is changed from vllm-wheels to vllm-wheels-dev in .buildkite/release-pipeline.yaml. I have identified a critical issue where the commented-out sections in .buildkite/release-pipeline.yaml should be removed to avoid confusion and potential errors in the future.

Comment thread .buildkite/release-pipeline.yaml
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@tjtanaa tjtanaa added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 28, 2026
@tjtanaa tjtanaa marked this pull request as ready for review February 28, 2026 14:48
@khluu khluu merged commit 5dfc5ab into vllm-project:main Mar 3, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Mar 3, 2026
khluu pushed a commit that referenced this pull request Mar 3, 2026
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
(cherry picked from commit 5dfc5ab)
Copilot AI pushed a commit to machov/vllm that referenced this pull request Mar 10, 2026
…-project#35198)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
avinashsingh77 pushed a commit to avinashsingh77/vllm that referenced this pull request Mar 12, 2026
…-project#35198)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
…-project#35198)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants