Skip to content

Remove padding_index from models that don't use it for better Transformers v5 compatibility #35189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 3 commits into from
Feb 24, 2026
Merged

Remove padding_index from models that don't use it for better Transformers v5 compatibility #35189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6411bdd
Fix InternS1-Pro for Transformers v5
hmellor Feb 24, 2026
9a46e5c
Remove `padding_index` from models that don't use it
hmellor Feb 24, 2026
da44da1
Remove InternS1Pro workaround
hmellor Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion vllm/model_executor/models/ernie45_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
cache_config = vllm_config.cache_config
quant_config = vllm_config.quant_config

self.padding_idx = config.pad_token_id
self.vocab_size = config.vocab_size
self.config = config
parallel_config = vllm_config.parallel_config
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/ernie45_vl_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
cache_config = vllm_config.cache_config
quant_config = vllm_config.quant_config

self.padding_idx = config.pad_token_id
self.vocab_size = config.vocab_size
self.config = config

Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/granitemoeshared.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):

self.config = config
self.quant_config = quant_config # Required by MixtralModel
self.padding_idx = config.pad_token_id

self.vocab_size = config.vocab_size

Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/grok1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,6 @@ def __init__(

self.config = config
self.quant_config = quant_config
self.padding_idx = config.pad_token_id

# Store expert naming for weight loading
self.ckpt_gate_proj_name = ckpt_gate_proj_name
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/hunyuan_v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):

self.config = config
self.quant_config = quant_config
self.padding_idx = config.pad_token_id

self.vocab_size = config.vocab_size

Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/jais2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,6 @@ def __init__(

self.config = config
self.quant_config = quant_config
self.padding_idx = config.pad_token_id

self.vocab_size = config.vocab_size
self.org_vocab_size = config.vocab_size
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/kimi_linear.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
parallel_config = vllm_config.parallel_config
self.config = config

self.padding_idx = config.pad_token_id
self.vocab_size = config.vocab_size

if get_pp_group().is_first_rank:
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/longcat_flash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
quant_config = vllm_config.quant_config
self.config = config

self.padding_idx = getattr(config, "pad_token_id", None)
self.vocab_size = config.vocab_size

if get_pp_group().is_first_rank:
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/minimax_text_01.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
cache_config = vllm_config.cache_config
scheduler_config = vllm_config.scheduler_config

self.padding_idx = config.pad_token_id
self.vocab_size = config.vocab_size

self.decoder_attention_types = getattr(
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/nemotron_nas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,6 @@ def __init__(

self.config = config
self.quant_config = quant_config
self.padding_idx = config.pad_token_id

self.vocab_size = config.vocab_size

Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/openpangu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
self.config = config
self.num_redundant_experts = eplb_config.num_redundant_experts

self.padding_idx = config.pad_token_id
self.vocab_size = config.vocab_size

if get_pp_group().is_first_rank or (
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/plamo2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,7 +748,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
config = vllm_config.model_config.hf_config

self.config = config
self.padding_idx = config.pad_token_id
self.vocab_size = config.vocab_size

self.embed_tokens = VocabParallelEmbedding(
Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/plamo3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,6 @@ def __init__(self, *, vllm_config: VllmConfig, prefix: str = ""):
config = vllm_config.model_config.hf_config

self.config = config
self.padding_idx = config.pad_token_id
self.vocab_size = config.vocab_size
self.org_vocab_size = config.vocab_size

Expand Down
1 change: 0 additions & 1 deletion vllm/model_executor/models/qwen3_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,6 @@ def __init__(
eplb_config = parallel_config.eplb_config
self.num_redundant_experts = eplb_config.num_redundant_experts

self.padding_idx = config.pad_token_id
self.vocab_size = config.vocab_size
self.config = config
self.quant_config = quant_config
Expand Down
Loading