Skip to content

[ROCm] Split wvSplitKrc into deterministic/fast kernels, add --fast-skinny-gemm CLI flag, overhaul tests #35183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AndreasKaratzas wants to merge 15 commits into from
Closed

[ROCm] Split wvSplitKrc into deterministic/fast kernels, add --fast-skinny-gemm CLI flag, overhaul tests #35183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
6c6ee71
Add padding support to wvsplitKrc, adjust header to match
amd-hhashemi Feb 11, 2026
dfbbc94
Merge branch 'vllm-project:main' into wvSplitKrc4
amd-hhashemi Feb 11, 2026
9043436
Merge branch 'vllm-project:main' into wvSplitKrc4
amd-hhashemi Feb 12, 2026
299de83
Merge branch 'main' into wvSplitKrc4
amd-hhashemi Feb 14, 2026
f8d5ac7
Merge branch 'vllm-project:main' into wvSplitKrc4
amd-hhashemi Feb 20, 2026
bdfd2fa
Add deterministic path to wvSplitKrc
amd-hhashemi Feb 20, 2026
4cbd1d6
Merge remote-tracking branch 'amd-hhashemi/wvSplitKrc4' into akaratza…
AndreasKaratzas Feb 23, 2026
763ccf4
Prototyping deterministic skinny GEMM feature
AndreasKaratzas Feb 24, 2026
591766d
Setting determinism mode and added test for skinny GEMMs
AndreasKaratzas Feb 24, 2026
2f87862
[ROCm][CI] Adding skinny gemms test
AndreasKaratzas Feb 24, 2026
51615bb
Merge remote-tracking branch 'origin/main' into akaratza_skinny_gemm_…
AndreasKaratzas Feb 24, 2026
834db4c
Merge remote-tracking branch 'origin/main' into akaratza_skinny_gemm_…
AndreasKaratzas Feb 25, 2026
417286e
Updated the distinct perf and accuracy skinny GEMM paths
AndreasKaratzas Feb 25, 2026
f1adff1
Added compile mode orthogonal to eager for the e2e test
AndreasKaratzas Feb 25, 2026
1f99db2
Merge remote-tracking branch 'origin/main' into akaratza_skinny_gemm_…
AndreasKaratzas Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csrc/rocm/ops.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ torch::Tensor wvSplitK(const at::Tensor& in_a, const at::Tensor& in_b,

torch::Tensor wvSplitKrc(const at::Tensor& in_a, const at::Tensor& in_b,
const std::optional<at::Tensor>& in_bias,
const int64_t CuCount);
const int64_t CuCount, const bool fast_skinny_gemm);

void wvSplitKQ(const at::Tensor& in_a, const at::Tensor& in_b,
const std::optional<at::Tensor>& in_bias, at::Tensor& out_c,
Expand Down
Loading