Skip to content

[CI][AMD][BugFix][P/D] Skip test_moriio_connector.py tests if IB verbs is not available#35164

Closed
rasmith wants to merge 4 commits intovllm-project:mainfrom
rasmith:ransmith_moriio_test_ibv
Closed

[CI][AMD][BugFix][P/D] Skip test_moriio_connector.py tests if IB verbs is not available#35164
rasmith wants to merge 4 commits intovllm-project:mainfrom
rasmith:ransmith_moriio_test_ibv

Conversation

@rasmith
Copy link
Contributor

@rasmith rasmith commented Feb 24, 2026

Purpose

Currently, the MORI KV connector requires IB verbs in order to run. However, some test machines might not have this requirement. This PR adds the ability to perform this check until TCP is added as a backend for MORI KV connector. If the ibv_devices command is not available, then the test is skipped. If ibv_devices does not return sufficient output, the test is also skipped.

Test Plan

pytest -sv v1/kv_connector/unit/test_moriio_connector.py

Test Result

Test correctly skips if ibv_devices is not available or if sufficient not available.


Essential Elements of an Effective PR Description Checklist
  • [ X] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • [ X] The test plan, such as providing test command.
  • [ X] The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Randall Smith <Randall.Smith@amd.com>
@mergify mergify bot added rocm Related to AMD ROCm v1 bug Something isn't working kv-connector labels Feb 24, 2026
@github-project-automation github-project-automation bot moved this to Todo in AMD Feb 24, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a check to skip test_moriio_connector.py if IB verbs are not available, which is a good improvement for CI stability on machines without the necessary hardware/software. My review focuses on making the availability check more robust. I've identified a potential crash due to an unhandled exception and suggest a refactoring that also simplifies the code and removes a debug print statement.

@mergify
Copy link

mergify bot commented Feb 24, 2026

Hi @rasmith, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Signed-off-by: Randall Smith <Randall.Smith@amd.com>
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
@mergify
Copy link

mergify bot commented Feb 24, 2026

Hi @rasmith, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Signed-off-by: Randall Smith <Randall.Smith@amd.com>
@rasmith rasmith closed this Feb 24, 2026
@github-project-automation github-project-automation bot moved this from Todo to Done in AMD Feb 24, 2026
@rasmith
Copy link
Contributor Author

rasmith commented Feb 24, 2026

Closed in favor of #34923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working kv-connector rocm Related to AMD ROCm v1

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant