[CI][AMD][BugFix][P/D] Skip test_moriio_connector.py tests if IB verbs is not available#35164
[CI][AMD][BugFix][P/D] Skip test_moriio_connector.py tests if IB verbs is not available#35164rasmith wants to merge 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
There was a problem hiding this comment.
Code Review
This pull request adds a check to skip test_moriio_connector.py if IB verbs are not available, which is a good improvement for CI stability on machines without the necessary hardware/software. My review focuses on making the availability check more robust. I've identified a potential crash due to an unhandled exception and suggest a refactoring that also simplifies the code and removes a debug print statement.
|
Hi @rasmith, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
|
Hi @rasmith, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
|
Closed in favor of #34923 |
Purpose
Currently, the MORI KV connector requires IB verbs in order to run. However, some test machines might not have this requirement. This PR adds the ability to perform this check until TCP is added as a backend for MORI KV connector. If the
ibv_devicescommand is not available, then the test is skipped. Ifibv_devicesdoes not return sufficient output, the test is also skipped.Test Plan
pytest -sv v1/kv_connector/unit/test_moriio_connector.pyTest Result
Test correctly skips if ibv_devices is not available or if sufficient not available.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.