[glm-asr] change defaults dummy audio size

[eustlb]

Purpose

models/multimodal/processing/test_common.py::test_processing_correctness[1.0-32-0.3-zai-org/GLM-ASR-Nano-2512] fails because of

vllm/vllm/model_executor/models/glmasr.py

Lines 913 to 914 in d13ece3

	if num_features == 0:
	raise ValueError("Audio is too short")

Indeed since merged_factor is 4, we need at least 4 mel-features, which is at 160 hop length 7 * 160 = 1120, ie 70ms at 16000Hz.

Test Plan

Test Result

---

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
• (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

[gemini-code-assist]

Code Review

This pull request changes the default dummy audio size for multimodal model tests, likely to accommodate requirements for the glm-asr model. While this fixes the issue for glm-asr, changing the default for all models could potentially cause issues for other models. I've suggested a more targeted change that applies the new audio sizes only when testing glm-asr, keeping the original defaults for other models. This will prevent unintended side effects.

[gemini-code-assist]

Based on the PR title, this change is intended for the glm-asr model. To avoid affecting other models, it's better to apply this change conditionally. You can do this inline as suggested, or for better readability, define variables for the audio sizes before this block and use them here and on line 347.

Suggested change

	"audio": (np.zeros((1024,)), 16000),
	"audio": (np.zeros((1024 if model_config.hf_config.model_type == "glmasr" else 512,)), 16000),

[gemini-code-assist]

Similarly, these values should be set conditionally for glm-asr to avoid affecting other models. You can do this inline as suggested, or for better readability, define variables for the audio sizes before the input_to_hit block and use them here.

Suggested change

	"audio": partial(random_audio, rng, min_len=1024, max_len=1536, sr=16000),
	"audio": partial(random_audio, rng, min_len=1024 if model_config.hf_config.model_type == "glmasr" else 512, max_len=1536 if model_config.hf_config.model_type == "glmasr" else 1024, sr=16000),

[mergify]

Hi @eustlb, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint