Skip to content

Use Xet high performance mode for Transformers v5#35098

Merged
vllm-bot merged 2 commits intovllm-project:mainfrom
hmellor:v5-xet-high-perf
Feb 23, 2026
Merged

Use Xet high performance mode for Transformers v5#35098
vllm-bot merged 2 commits intovllm-project:mainfrom
hmellor:v5-xet-high-perf

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Feb 23, 2026

Enable high performance mode for Xet when Transformers v5 is installed, falling back to hf_transfer for Transformers v4. This change optimizes performance based on the installed version of the Transformers library.

…s v5 installed

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor requested a review from 22quinn as a code owner February 23, 2026 12:59
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the logic for enabling high-performance download modes in huggingface_hub to support both Transformers v4 and v5. The change correctly detects the huggingface_hub version and enables either Xet high-performance mode (for v5) or hf_transfer (for v4). However, the implementation for enabling Xet mode unconditionally sets HF_XET_HIGH_PERFORMANCE to True, which overrides any user-defined environment variable setting. I've suggested a change to respect the user's environment configuration, making it consistent with the existing logic for hf_transfer.

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though I'm not sure whether we should force users to enable this mode

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 23, 2026 13:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 23, 2026
@hmellor
Copy link
Member Author

hmellor commented Feb 23, 2026

In v4 we would force hf_transfer if it was installed, but didn't want to force the extra dependency.

For v5 I think this is safe because all it does is boost the number of CPU cores used in order to saturate network/disk bandwidth while downloading models. (docs). Since it doesn't require an extra dependency and can still be disabled by users who really don't want it, it should be ok.

@vllm-bot vllm-bot merged commit c4f3869 into vllm-project:main Feb 23, 2026
49 of 51 checks passed
@hmellor hmellor deleted the v5-xet-high-perf branch February 23, 2026 16:23
llsj14 pushed a commit to llsj14/vllm that referenced this pull request Mar 1, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
tunglinwood pushed a commit to tunglinwood/vllm that referenced this pull request Mar 4, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
askliar pushed a commit to askliar/vllm that referenced this pull request Mar 9, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Andrii Skliar <askliar@nvidia.com>
Copilot AI pushed a commit to machov/vllm that referenced this pull request Mar 10, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants