Skip to content

[Core] Fix state names in pause_scheduler()#34840

Merged
WoosukKwon merged 1 commit intovllm-project:mainfrom
markmc:pause-scheduler-docs
Feb 20, 2026
Merged

[Core] Fix state names in pause_scheduler()#34840
WoosukKwon merged 1 commit intovllm-project:mainfrom
markmc:pause-scheduler-docs

Conversation

@markmc
Copy link
Member

@markmc markmc commented Feb 18, 2026

Looks like this got changed during #34125 iterations, but the docs got out of sync.

@markmc markmc requested a review from njhill February 18, 2026 18:52
@markmc
Copy link
Member Author

markmc commented Feb 18, 2026

/cc @hao-aaron

@mergify mergify bot added the v1 label Feb 18, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly updates the pause_scheduler docstring to align with the current implementation and the PauseState enum. I have identified a typo in the abort mode description where PAUSE_NEW is used instead of PAUSED_NEW.

Looks like this got changed during vllm-project#34125 iterations, but the docs
got out of sync.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
@markmc markmc force-pushed the pause-scheduler-docs branch from 666e1eb to 6aee682 Compare February 18, 2026 18:56
Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markmc

@WoosukKwon WoosukKwon merged commit 76df607 into vllm-project:main Feb 20, 2026
6 checks passed
jmamou pushed a commit to jmamou/vllm that referenced this pull request Feb 23, 2026
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
llsj14 pushed a commit to llsj14/vllm that referenced this pull request Mar 1, 2026
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
tunglinwood pushed a commit to tunglinwood/vllm that referenced this pull request Mar 4, 2026
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
askliar pushed a commit to askliar/vllm that referenced this pull request Mar 9, 2026
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Andrii Skliar <askliar@nvidia.com>
Copilot AI pushed a commit to machov/vllm that referenced this pull request Mar 10, 2026
Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants