Skip to content

Revert "[NemotronH] Do not force router to run in fp32 (#34582)" #34808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 3 commits into from
Feb 19, 2026
Merged

Revert "[NemotronH] Do not force router to run in fp32 (#34582)" #34808

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a57c2eb
Revert "[NemotronH] Do not force router to run in fp32 (#34582)"
roikoren755 Feb 18, 2026
c7c5142
Leave this in
roikoren755 Feb 18, 2026
1eac481
Merge branch 'main' into feat/nemotronh-router-revert
mgoin Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vllm/model_executor/models/nemotron_h.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,10 +148,12 @@ def __init__(

self.is_sequence_parallel = parallel_config.use_sequence_parallel_moe

router_logits_dtype = torch.float32
self.gate = ReplicatedLinear(
config.hidden_size,
config.n_routed_experts,
bias=False,
params_dtype=router_logits_dtype,
quant_config=None,
prefix=f"{prefix}.gate",
)
Expand Down Expand Up @@ -230,6 +232,7 @@ def __init__(
enable_eplb=self.enable_eplb,
num_redundant_experts=self.n_redundant_experts,
is_sequence_parallel=self.is_sequence_parallel,
router_logits_dtype=router_logits_dtype,
routed_input_transform=self.fc1_latent_proj,
)

Expand All @@ -241,7 +244,7 @@ def forward(self, hidden_states: torch.Tensor) -> torch.Tensor:
hidden_states = sequence_parallel_chunk(hidden_states)

# router_logits: (num_tokens, n_experts)
router_logits, _ = self.gate(hidden_states)
router_logits, _ = self.gate(hidden_states.to(dtype=torch.float32))

# SharedFusedMoE handles:
# - shared experts (with original hidden_states)
Expand Down
Loading