Skip to content

[Build] Update numba version to 0.63.1.#34764

Closed
nascheme wants to merge 3 commits into
vllm-project:mainfrom
nascheme:numba_0_63
Closed

[Build] Update numba version to 0.63.1.#34764
nascheme wants to merge 3 commits into
vllm-project:mainfrom
nascheme:numba_0_63

Conversation

@nascheme
Copy link
Copy Markdown
Contributor

@nascheme nascheme commented Feb 18, 2026

Purpose

For vLLM to support Python 3.14, we need to use a newer version of numba. Version 0.63 of numba adds support for 3.14.

Test Plan

Run ngram_proposer tests using pytest.

Test Result

The unit tests using ngram_proposer pass.

@nascheme nascheme requested a review from tjtanaa as a code owner February 18, 2026 02:18
@mergify mergify Bot added ci/build nvidia rocm Related to AMD ROCm labels Feb 18, 2026
@mergify mergify Bot added the cpu Related to CPU backends label Feb 18, 2026
@github-project-automation github-project-automation Bot moved this to Todo in AMD Feb 18, 2026
@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Feb 18, 2026
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the numba dependency to version 0.63.1 across all requirement files. While the change itself is straightforward and the tests are passing, the provided justification appears to be incorrect. The pull request description states this update is for Python 3.14 support, but numba version 0.63.1 only adds initial support for Python 3.13. This discrepancy is a high-severity issue as it misrepresents the capabilities of the updated dependency and may lead to future build issues if Python 3.14 support is assumed to be in place.

Comment thread requirements/cpu.txt
@@ -3,7 +3,7 @@

setuptools==77.0.3 # this version can reuse CMake build dir

numba == 0.61.2; platform_machine != "s390x" # Required for N-gram speculative decoding
numba == 0.63.1; platform_machine != "s390x" # Required for N-gram speculative decoding
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The stated purpose of this pull request is to add support for Python 3.14 by upgrading numba. However, numba version 0.63.1 does not provide support for Python 3.14; it introduces initial support for Python 3.13. This means the current change does not achieve the stated goal. A newer version of numba will be necessary to support Python 3.14 when it becomes available.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the release notes, 3.14 support is explicitly noted.

@nascheme
Copy link
Copy Markdown
Contributor Author

I'm not sure of the PR workflow on this project, am I supposed to merge my own PR once approved? There are some CI test failures but my impression is those are not related to this change. I'm going to merge with "main" and that will hopefully re-run the tests.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 20, 2026 04:11
@DarkLight1337
Copy link
Copy Markdown
Member

Sorry CI was broken for the past few days, let's see if it passes now.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 21, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @nascheme.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Feb 21, 2026
Signed-off-by: Neil Schemenauer <nas@arctrix.com>
auto-merge was automatically disabled February 21, 2026 20:10

Head branch was pushed to by a user without write access

@mergify mergify Bot removed the needs-rebase label Feb 21, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 9, 2026

Hi @nascheme, the pre-commit checks have failed. Please run:

uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy failing?
mypy is run differently in CI. If the failure is related to this check, please use the following command to run it locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 10, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @nascheme.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Apr 10, 2026
@Harry-Chen
Copy link
Copy Markdown
Member

Included in #34770.

@Harry-Chen Harry-Chen closed this Apr 25, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in AMD Apr 25, 2026
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build cpu Related to CPU backends needs-rebase nvidia ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants