[Build] Update numba version to 0.63.1.#34764
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the numba dependency to version 0.63.1 across all requirement files. While the change itself is straightforward and the tests are passing, the provided justification appears to be incorrect. The pull request description states this update is for Python 3.14 support, but numba version 0.63.1 only adds initial support for Python 3.13. This discrepancy is a high-severity issue as it misrepresents the capabilities of the updated dependency and may lead to future build issues if Python 3.14 support is assumed to be in place.
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| setuptools==77.0.3 # this version can reuse CMake build dir | |||
|
|
|||
| numba == 0.61.2; platform_machine != "s390x" # Required for N-gram speculative decoding | |||
| numba == 0.63.1; platform_machine != "s390x" # Required for N-gram speculative decoding | |||
There was a problem hiding this comment.
The stated purpose of this pull request is to add support for Python 3.14 by upgrading numba. However, numba version 0.63.1 does not provide support for Python 3.14; it introduces initial support for Python 3.13. This means the current change does not achieve the stated goal. A newer version of numba will be necessary to support Python 3.14 when it becomes available.
There was a problem hiding this comment.
See the release notes, 3.14 support is explicitly noted.
|
I'm not sure of the PR workflow on this project, am I supposed to merge my own PR once approved? There are some CI test failures but my impression is those are not related to this change. I'm going to merge with "main" and that will hopefully re-run the tests. |
|
Sorry CI was broken for the past few days, let's see if it passes now. |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Neil Schemenauer <nas@arctrix.com>
Head branch was pushed to by a user without write access
|
Hi @nascheme, the pre-commit checks have failed. Please run: uv pip install pre-commit>=4.5.1
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
This pull request has merge conflicts that must be resolved before it can be |
|
Included in #34770. |
Purpose
For vLLM to support Python 3.14, we need to use a newer version of numba. Version 0.63 of numba adds support for 3.14.
Test Plan
Run ngram_proposer tests using pytest.
Test Result
The unit tests using ngram_proposer pass.