[Bugfix] fix activation in cpu_fused_moe_torch call#34696
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Feb 18, 2026
Merged
[Bugfix] fix activation in cpu_fused_moe_torch call#34696vllm-bot merged 1 commit intovllm-project:mainfrom
vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Marek Michalowski <marek.michalowski@arm.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the cpu_fused_moe_torch call within the forward_torch method. The activation parameter was previously passed as a MoEActivation enum object, but the cpu_fused_moe_torch function expects a string. The change correctly passes activation.value, which provides the string representation of the activation function. This fix is correct and resolves the type mismatch issue.
Contributor
|
@mgoin / @bigPYJ1151 could you please take a look? |
jasonozuzu-cohere
pushed a commit
to jasonozuzu-cohere/vllm
that referenced
this pull request
Feb 18, 2026
Signed-off-by: Marek Michalowski <marek.michalowski@arm.com> Signed-off-by: Jason Ozuzu <jasonozuzu@cohere.com>
ZJY0516
pushed a commit
to ZJY0516/vllm
that referenced
this pull request
Feb 23, 2026
Signed-off-by: Marek Michalowski <marek.michalowski@arm.com> Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
Signed-off-by: Marek Michalowski <marek.michalowski@arm.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
Signed-off-by: Marek Michalowski <marek.michalowski@arm.com>
askliar
pushed a commit
to askliar/vllm
that referenced
this pull request
Mar 9, 2026
Signed-off-by: Marek Michalowski <marek.michalowski@arm.com> Signed-off-by: Andrii Skliar <askliar@nvidia.com>
Copilot AI
pushed a commit
to machov/vllm
that referenced
this pull request
Mar 10, 2026
Signed-off-by: Marek Michalowski <marek.michalowski@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the bug in #34689 introduced by #33843. Now passing
activation.valueinstead ofactivationtocpu_fused_moe_torchsince it expects a str argument.