[ROCm] Enable DeepEP ROCm as all2allbackend for AMD GPUs. - #34692
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Code Review
This pull request enables DeepEP on ROCm for AMD GPUs by adding platform-specific logic, particularly for handling the float8_e4m3fnuz data type and adjusting API arguments. The changes are consistent across the modified files. My main feedback is to refactor a piece of duplicated code in all2all.py to improve maintainability.
|
cc: @itej89 @amathews-amd |
|
Ran the following tests locally and all succeeded. |
|
cc: @HAIAI |
|
Documentation preview: https://vllm--34692.org.readthedocs.build/en/34692/ |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Tej Kiran <vpolamre@amd.com>
Signed-off-by: Tej Kiran <vpolamre@amd.com>
Signed-off-by: Tej Kiran <vpolamre@amd.com>
Signed-off-by: Tej Kiran <vpolamre@amd.com>
Signed-off-by: Tej Kiran <vpolamre@amd.com>
Signed-off-by: Tej Kiran <vpolamre@amd.com>
|
Please find the DeepEP Unit Test Pass Results on the image built using the newly added docker file "docker/Dockerfile.rocm_deepep" below |
Above can be ignored - since: |
|
Please find the updated test results in alignment with the latest updates below Test PlanAccuracyMI300 + CX7Serve on 1N DeepSeek-V3 with DeepEP - Low Latency | High Throughput Serve on 2N DeepSeek-V3 with DeepEP - Low Latency GSM8K Evaluation Test ResultsAccuracyGSM8K Evaluation Results Serve on 1N DeepSeek-V3 with DeepEP - High Throughput Serve on 2N DeepSeek-V3 with DeepEP - Low Latency Serve on 2N DeepSeek-V3 with DeepEP - High Throughput |
|
@houseroad @njhill This PR is ready to merge, would you mind to have a look? |
|
The CI failures seem unrelated to the PRs and the AMD-CI is successful. This PR is ready for merge with whoever has merge access. |
|
Thanks @lcskrishna @HAIAI! Could you merge in main one more time? |
@njhill As requested, I've merged the main. Thanks!! |
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com>
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com>
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com> Signed-off-by: Nithin Chalapathi <nithin.ch10@gmail.com>
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com>
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com>
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com>
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com>
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com>
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com> Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
…ct#34692) Signed-off-by: Tej Kiran <vpolamre@amd.com> Co-authored-by: Tej Kiran <vpolamre@amd.com>
This PR is to integrate changes required to run DeepEP as an all2allbackend on AMD GPUs.
co-authored by : @itej89
The following changes are performed:
Related steps:
cc: @kenroche
Purpose
Test Plan
Accuracy Test
MI300 + CX7
Serve on 1N DeepSeek-V3 with DeepEP - Low Latency | High Throughput
Serve on 2N DeepSeek-V3 with DeepEP - Low Latency
Serve 1P1D through RIXL
GSM8K Evaluation
Test Result
Accuracy Results
GSM8K Evaluation Results
Serve on 1N DeepSeek-V3 with DeepEP - Low Latency
Serve on 1N DeepSeek-V3 with DeepEP - High Throughput
Serve on 2N DeepSeek-V3 with DeepEP - Low Latency
Serve on 2N DeepSeek-V3 with DeepEP - High Throughput
Serve 1P1D on RIXL
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.