[CI][AMD][BugFix] Skip tests in test_unquantized_backend_selection that should not run on ROCm#34655
Merged
yewentao256 merged 5 commits intovllm-project:mainfrom Feb 18, 2026
Conversation
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
rasmith
requested review from
WoosukKwon,
mgoin,
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly skips CUDA-specific tests in test_unquantized_backend_selection.py when running on non-CUDA platforms like ROCm. The changes are straightforward and use pytest.mark.skipif with current_platform.is_cuda() to conditionally disable tests, which is the correct approach for this scenario. The implementation is clean and addresses the CI bug effectively. I have no further comments.
yewentao256
approved these changes
Feb 17, 2026
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
yewentao256
approved these changes
Feb 18, 2026
jmamou
pushed a commit
to jmamou/vllm
that referenced
this pull request
Feb 23, 2026
…at should not run on ROCm (vllm-project#34655) Signed-off-by: Randall Smith <Randall.Smith@amd.com>
Copilot AI
pushed a commit
to machov/vllm
that referenced
this pull request
Mar 10, 2026
…at should not run on ROCm (vllm-project#34655) Signed-off-by: Randall Smith <Randall.Smith@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR introduced tests that are not able to run on ROCm, so a PR is needed to skip those tests on ROCm platforms, in addition to any other platforms that are not applicable.
Test Plan
pytest -sv kernels/moeTest Result
1956 passed, 5402 skipped, 8 warnings
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.