[Bugfix][CI] Fix flaky entrypoints/openai/test_response_api_with_harmony.py::test_function_calling[openai/gpt-oss-20b]#34624
Merged
DarkLight1337 merged 2 commits intomainfrom Feb 16, 2026
Merged
Conversation
NickLucche
requested review from
DarkLight1337,
aarnphm and
robertgshaw2-redhat
as code owners
DarkLight1337
approved these changes
Feb 16, 2026
github-project-automation
bot
moved this from To Triage
to Ready
in gpt-oss Issues & Enhancements
github-actions
bot
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky test by replacing a live API call to an external weather service with a hardcoded value. This change effectively stubs the external dependency, which is a good practice to ensure test reliability and prevent failures due to network issues. The implementation is straightforward and correctly resolves the flakiness. The change is approved.
github-project-automation
bot
moved this from Ready
to Done
in gpt-oss Issues & Enhancements
wzhao18
pushed a commit
to wzhao18/vllm
that referenced
this pull request
Feb 18, 2026
…mony.py::test_function_calling[openai/gpt-oss-20b]` (vllm-project#34624) Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
…mony.py::test_function_calling[openai/gpt-oss-20b]` (vllm-project#34624) Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
ZJY0516
pushed a commit
to ZJY0516/vllm
that referenced
this pull request
Feb 23, 2026
…mony.py::test_function_calling[openai/gpt-oss-20b]` (vllm-project#34624) Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
…mony.py::test_function_calling[openai/gpt-oss-20b]` (vllm-project#34624) Signed-off-by: NickLucche <nlucches@redhat.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
…mony.py::test_function_calling[openai/gpt-oss-20b]` (vllm-project#34624) Signed-off-by: NickLucche <nlucches@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky test
entrypoints/openai/test_response_api_with_harmony.py::test_function_calling[openai/gpt-oss-20b]by mocking the call to open-meteo API to avoid unnecessary connection errors in CI such as:PS we don't actually care about the weather in beautiful Paris