(bugfix): Fixed encode in LLM entrypoint for IOProcessr plugin prompts#34618
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Feb 16, 2026
Merged
(bugfix): Fixed encode in LLM entrypoint for IOProcessr plugin prompts#34618vllm-bot merged 1 commit intovllm-project:mainfrom
vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
christian-pinto
requested review from
DarkLight1337 and
noooop
as code owners
5 tasks
|
Documentation preview: https://vllm--34618.org.readthedocs.build/en/34618/ |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a bug in the LLM.encode method for IO Processor plugin prompts. The change in vllm/entrypoints/llm.py modifies the argument passed to the io_processor.parse_data method. While the change itself seems to align with the PR description, the corresponding changes in the test and example files appear to contradict the fix, potentially making it ineffective. I've added a critical comment detailing this concern.
github-actions
bot
added
the
ready
wzhao18
pushed a commit
to wzhao18/vllm
that referenced
this pull request
Feb 18, 2026
vllm-project#34618) Signed-off-by: Christian Pinto <christian.pinto@ibm.com> Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
vllm-project#34618) Signed-off-by: Christian Pinto <christian.pinto@ibm.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
ZJY0516
pushed a commit
to ZJY0516/vllm
that referenced
this pull request
Feb 23, 2026
vllm-project#34618) Signed-off-by: Christian Pinto <christian.pinto@ibm.com> Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
5 tasks
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
vllm-project#34618) Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
vllm-project#34618) Signed-off-by: Christian Pinto <christian.pinto@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a bug in encode in the LLM entrypoint when using IO Processor plugins.
Previously in
encodewe would verify that the request is meant to use an IO Processor plugin, and then pass the full prompt to theparse_dataof the IO Processor plugin. While we should only pass theprompt.datafield to the plugin, similarly to what is done in the online serving mode.This came out of a discussion in #34214
@DarkLight1337 @staugust
Test Plan
Modified test to pass a properly formatted prompt to vllm when performing the inference in offline mode.
Test Result