Skip to content

[NemotronH] Do not force router to run in fp32 #34582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 4 commits into from
Feb 16, 2026
Merged

[NemotronH] Do not force router to run in fp32 #34582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
608fbdf
Do not force NemotronH router to fp32
roikoren755 Feb 15, 2026
48ab68e
Fix router logits dtype mismatch
roikoren755 Feb 15, 2026
8301f2c
Delete debugging print
roikoren755 Feb 15, 2026
7e58b85
Remove unnecessary .to call
roikoren755 Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions vllm/model_executor/layers/fused_moe/flashinfer_trtllm_moe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,10 @@ def fi_trtllm_fp8_per_tensor_moe(

from vllm.utils.flashinfer import flashinfer_trtllm_fp8_per_tensor_scale_moe

# The DeepSeekV3 routing method requires float32 router logits.
if routing_method_type == RoutingMethodType.DeepSeekV3:
routing_logits = routing_logits.to(torch.float32)

return flashinfer_trtllm_fp8_per_tensor_scale_moe(
routing_logits=routing_logits,
routing_bias=routing_bias,
Expand Down
5 changes: 1 addition & 4 deletions vllm/model_executor/models/nemotron_h.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,10 @@ def __init__(

self.is_sequence_parallel = parallel_config.use_sequence_parallel_moe

router_logits_dtype = torch.float32
self.gate = ReplicatedLinear(
config.hidden_size,
config.n_routed_experts,
bias=False,
params_dtype=router_logits_dtype,
quant_config=None,
prefix=f"{prefix}.gate",
)
Expand Down Expand Up @@ -232,7 +230,6 @@ def __init__(
enable_eplb=self.enable_eplb,
num_redundant_experts=self.n_redundant_experts,
is_sequence_parallel=self.is_sequence_parallel,
router_logits_dtype=router_logits_dtype,
routed_input_transform=self.fc1_latent_proj,
)

Expand All @@ -244,7 +241,7 @@ def forward(self, hidden_states: torch.Tensor) -> torch.Tensor:
hidden_states = sequence_parallel_chunk(hidden_states)

# router_logits: (num_tokens, n_experts)
router_logits, _ = self.gate(hidden_states.to(dtype=torch.float32))
router_logits, _ = self.gate(hidden_states)

# SharedFusedMoE handles:
# - shared experts (with original hidden_states)
Expand Down