Conversation
… strides…" This reverts commit d7982da.
5 tasks
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly reverts the explicit typing of stride parameters to tl.int64 in the fused_moe_kernel_gptq_awq and fused_moe_kernel Triton kernels. The motivation for this revert is to address significant performance degradations introduced by the original change. While this action knowingly reintroduces a bug concerning potential integer overflows with very large tensors, it is a pragmatic trade-off to restore performance. The intention to investigate a more performant solution for the overflow issue is acknowledged. The revert is implemented correctly.
tlrmchlsmth
approved these changes
Feb 13, 2026
4 tasks
haosdent
added a commit
to haosdent/vllm
that referenced
this pull request
Feb 14, 2026
…egression PR vllm-project#34279 annotated all stride parameters as tl.int64 to fix an int32 overflow crash, but this caused ~60x perf regression on small GPUs (e.g. NVIDIA GB10) due to register pressure. PR vllm-project#34530 reverted that fix. This patch prevents the overflow with minimal register impact by casting offs_token to int64 after loading instead of widening all strides. When chunking is disabled and M is large, stride_cm * offs_token (where stride_cm = N = w1.size(1) and offs_token up to M*topk) can exceed int32 max. The cast leverages Triton type promotion (int32 * int64 -> int64) following the existing pattern used for off_experts and offs_bn. Adds a regression test that disables chunking with M=100000, n=2048, topk=6 (product = 4096 * 600000 = 2.46B > int32 max) and validates correctness against the torch_moe reference. Fixes vllm-project#34413 Signed-off-by: haosdent <haosdent@gmail.com>
wzhao18
pushed a commit
to wzhao18/vllm
that referenced
this pull request
Feb 18, 2026
… strides" (vllm-project#34530) Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
… strides" (vllm-project#34530) Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
ZJY0516
pushed a commit
to ZJY0516/vllm
that referenced
this pull request
Feb 23, 2026
… strides" (vllm-project#34530) Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #34279 due to large performance degradations reported. We will search for a similar result with more careful performance analysis later