Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/entrypoints/pooling/pooling/serving.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ async def create_pooling(
"offline inference example for more details."
)

validated_prompt = self.io_processor.parse_data(request.data)
validated_prompt = self.io_processor.parse_data(request)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change passes the entire request object (which is an IOProcessorRequest) to self.io_processor.parse_data. This alters the expected input type for IOProcessor.parse_data implementations. Previously, plugins would receive request.data (type T from IOProcessorRequest[T]), but now they will receive the IOProcessorRequest object itself. This is a breaking change for existing plugins that implement IOProcessor.parse_data expecting the previous data type. To prevent runtime errors and ensure type safety, the IOProcessor.parse_data method's signature in vllm/plugins/io_processors/interface.py should be updated to parse_data(self, request: IOProcessorRequest) -> IOProcessorInput: to reflect this new expectation.


raw_prompts = await self.io_processor.pre_process_async(
prompt=validated_prompt, request_id=request_id
Expand Down