[KV Connector] Add temporary, off-by-default VLLM_DISABLE_REQUEST_ID_RANDOMIZATION workaround#34415
Conversation
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new, temporary, opt-in environment variable VLLM_DISABLE_REQUEST_ID_RANDOMIZATION. This flag allows users to disable the automatic randomization of request ID suffixes, which is a hotfix for compatibility with connectors like P2pNcclConnector that require consistent request IDs across distributed instances.
The changes are well-implemented and minimal:
- A new environment variable
VLLM_DISABLE_REQUEST_ID_RANDOMIZATIONis added invllm/envs.py, following existing patterns for boolean flags in the project. - The request ID randomization logic in
vllm/v1/engine/input_processor.pyis now conditional on this new flag.
The implementation is clean, straightforward, and ensures backward compatibility since the new behavior is opt-in. I have reviewed the changes and found no issues of high or critical severity.
VLLM_DISABLE_REQUEST_ID_RANDOMIZATIONVLLM_DISABLE_REQUEST_ID_RANDOMIZATION workaround
|
We should add a warning that enabling this may cause failures and/or subtle correctness errors if there are any duplicate externally-provided request ids. |
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
|
Thanks @njhill, done |
…_RANDOMIZATION` workaround (vllm-project#34415) Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: athrael-soju <athrael-soju@users.noreply.github.com>
…_RANDOMIZATION` workaround (vllm-project#34415) Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
…_RANDOMIZATION` workaround (vllm-project#34415) Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
…_RANDOMIZATION` workaround (vllm-project#34415) Signed-off-by: Seiji Eicher <seiji@anyscale.com> Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
…_RANDOMIZATION` workaround (vllm-project#34415) Signed-off-by: Seiji Eicher <seiji@anyscale.com>
…_RANDOMIZATION` workaround (vllm-project#34415) Signed-off-by: Seiji Eicher <seiji@anyscale.com>
v0.14.0and later adds a random suffix to frontend-provided request IDs - #27987This change broke several in-tree KV connectors that do not have CI coverage. See:
As a temporary measure, add a
VLLM_DISABLE_REQUEST_ID_RANDOMIZATION=1env var that will restore the pre-v0.14.0behavior so that users of these connectors can work around the breakage.This env var will be removed again in a forthcoming release.
Manual testing
Without fix
With
VLLM_DISABLE_REQUEST_ID_RANDOMIZATION=1, the warning is visible and fires only once