small adjustment to wvSplitKrc#34410
Merged
gshtras merged 2 commits intovllm-project:mainfrom Feb 12, 2026
Merged
Conversation
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a critical bug in the wvSplitKrc_ kernel. By clamping the kOffcp offset, it prevents a potential out-of-bounds memory access on the A tensor that was causing runtime failures. The change is correct and improves the kernel's robustness. No further issues were found.
5 tasks
gshtras
approved these changes
Feb 12, 2026
Collaborator
|
Confirming that this fixes the single prompt request to /completions on a server w/o AITER outputting "!!!!!" |
github-actions
bot
added
the
ready
gshtras
pushed a commit
to ROCm/vllm
that referenced
this pull request
Feb 16, 2026
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
gshtras
pushed a commit
to ROCm/vllm
that referenced
this pull request
Feb 17, 2026
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
gshtras
pushed a commit
to ROCm/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
gshtras
pushed a commit
to ROCm/vllm
that referenced
this pull request
Feb 20, 2026
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
gshtras
pushed a commit
to ROCm/vllm
that referenced
this pull request
Feb 23, 2026
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some vllm dockers, gpt-oss showing prompt fails without this change. Tests results unchanged.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.