[bugfix] refactor FunASR's _get_data_parser #34397
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Feb 12, 2026
Merged
[bugfix] refactor FunASR's _get_data_parser #34397DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly refactors the _get_data_parser method by moving it from FunASRMultiModalProcessor to FunASRProcessingInfo and renaming it to get_data_parser. This change aligns with the recent API updates in vLLM, ensuring compatibility and proper functionality. The implementation is clean, straightforward, and I have no further suggestions for improvement.
github-actions
bot
added
the
ready
Contributor
Author
|
buildkite/ci/pr/v1-e2e-plus-engine failed with message "FAILED v1/e2e/test_spec_decode.py::test_ngram_and_suffix_correctness[speculative_config1] - assert 52 >= 66", should I rebase onto latest main? @DarkLight1337 |
Member
|
No, it is a flaky test, let me retry it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BaseProcessingInfo.build_data_parserin v0.16. "@DarkLight1337 please take a look, thanks.
Related PR #33247