[BUG] Reset running requests when clearing cache for pause/resume#34382
Merged
robertgshaw2-redhat merged 1 commit intovllm-project:mainfrom Feb 12, 2026
Merged
[BUG] Reset running requests when clearing cache for pause/resume#34382robertgshaw2-redhat merged 1 commit intovllm-project:mainfrom
robertgshaw2-redhat merged 1 commit intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where in-progress requests would block clearing the prefix cache when pause_generation is called with mode="keep". The fix correctly passes reset_running_requests=True to reset_prefix_cache, ensuring that the state of running requests is properly handled when the cache is cleared. This change is safe for other modes (abort and wait) as there are no running requests in those scenarios. The fix is correct and well-contained.
robertgshaw2-redhat
approved these changes
Feb 11, 2026
github-actions
bot
added
the
ready
njhill
approved these changes
Feb 12, 2026
Member
njhill
left a comment
njhill
left a comment
There was a problem hiding this comment.
We should check the implications for the MM caches too.
robertgshaw2-redhat
merged commit 7b5a8b4
into
vllm-project:main
47 of 48 checks passed
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
…lm-project#34382) Signed-off-by: hao-aaron <ahao@anyscale.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
…lm-project#34382) Signed-off-by: hao-aaron <ahao@anyscale.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
…lm-project#34382) Signed-off-by: hao-aaron <ahao@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Addressing #32351 (comment), in progress requests block clearing prefix cache in keep mode.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.