Don't try and run GLM-ASR with remote code#34352
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Feb 11, 2026
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly removes the trust_remote_code=True argument for the GlmAsrForConditionalGeneration model in the test registry. As the model has been upstreamed to the Transformers library, this flag is no longer necessary. This is a good security enhancement, as it avoids potentially running untrusted remote code. The change is accurate and well-justified.
DarkLight1337
approved these changes
Feb 11, 2026
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GLM-ASR has been upstreamed to Transformers in huggingface/transformers@a7f2952 which was first released in
v5.0.0rc2.Therefore we should remove this kwarg from our test. (The test will not actually run in this PR because it's still gated on Transformesr v5)