Skip to content

[chore] Update FA #34276

Open
LucasWilkinson wants to merge 2 commits intovllm-project:mainfrom
neuralmagic:lwilkinson/update-fa
Open

[chore] Update FA #34276
LucasWilkinson wants to merge 2 commits intovllm-project:mainfrom
neuralmagic:lwilkinson/update-fa

Conversation

@LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Feb 10, 2026

Update FA to pickup

vllm-project/flash-attention#116

@mergify mergify bot added the ci/build label Feb 10, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pinned commit for the flash-attention dependency. The change is straightforward. My review includes one suggestion to improve maintainability by documenting the reason for this specific commit hash directly in the code, which is important for future maintenance of this dependency.

vllm-flash-attn
GIT_REPOSITORY https://github.com/vllm-project/flash-attention.git
GIT_TAG 86f8f157cf82aa2342743752b97788922dd7de43
GIT_TAG 1c81743f90ed982461bb3f9a0cef7aa361ee2f11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For long-term maintainability, it's crucial to document 'magic' values like this commit hash. While the PR description provides context, it's best practice to include this information directly in the code. Please add a comment explaining why this specific commit is being used. This will help future developers understand the dependency and make informed decisions when updating it.

          # Pick up fix from https://github.com/vllm-project/flash-attention/pull/116
          GIT_TAG 1c81743f90ed982461bb3f9a0cef7aa361ee2f11

@mergify
Copy link

mergify bot commented Feb 10, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LucasWilkinson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 10, 2026
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
@mergify
Copy link

mergify bot commented Feb 11, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LucasWilkinson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 11, 2026
Signed-off-by: Lucas Wilkinson <LucasWilkinson@users.noreply.github.com>
@mergify mergify bot removed the needs-rebase label Feb 11, 2026
@LucasWilkinson LucasWilkinson added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant