[Frontend] Exploit tokenizers "new stream" in FastIncrementalDetokenizer#34217
Merged
hmellor merged 2 commits intovllm-project:mainfrom Feb 11, 2026
Merged
[Frontend] Exploit tokenizers "new stream" in FastIncrementalDetokenizer#34217hmellor merged 2 commits intovllm-project:mainfrom
hmellor merged 2 commits intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively leverages the new native prefill feature in tokenizers>=0.22.0 to simplify and speed up the initialization of FastIncrementalDetokenizer. The change removes a significant amount of complex workaround code for priming the decode stream, which greatly improves code clarity and maintainability. The other minor refactorings in the file also enhance readability. The changes are correct and well-implemented. Overall, this is a great improvement.
Signed-off-by: Nick Hill <nickhill123@gmail.com>
Signed-off-by: Nick Hill <nickhill123@gmail.com>
njhill
force-pushed
the
detok-prefill
branch
from
8004c82 to
3218fa8
Compare
hmellor
approved these changes
Feb 11, 2026
Member
Author
|
Thanks again @ArthurZucker!! Sorry I realized afterwards I should have included you as co-author. |
Contributor
|
No no absolutely not! Happy its finally getting used hehe 🤗 |
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
…zer (vllm-project#34217) Signed-off-by: Nick Hill <nickhill123@gmail.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
…zer (vllm-project#34217) Signed-off-by: Nick Hill <nickhill123@gmail.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
…zer (vllm-project#34217) Signed-off-by: Nick Hill <nickhill123@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally remembered to revisit #18840.
Faster incremental detokenizer initialization.
Includes some unrelated minor code simplifications in
detokenizer.py.