[Bugfix][ROCm][GPT-OSS] Use old triton_kernels implementation on ROCm if the new API is not available#34153
Merged
gshtras merged 3 commits intovllm-project:mainfrom Feb 9, 2026
Conversation
… support triton 3.6 Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
mergify
bot
added
gpt-oss
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback mechanism to support older triton_kernels APIs on ROCm platforms, which may lack SparseMatrix and make_ragged_tensor_metadata. The changes correctly detect the platform and API availability to switch between legacy and modern implementations. However, I've identified a critical bug in the import logic that will cause a NameError on non-ROCm platforms. My review includes a suggested fix for this issue.
vllm/model_executor/layers/fused_moe/gpt_oss_triton_kernels_moe.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
This was referenced Feb 9, 2026
Merged
4 tasks
mgoin
approved these changes
Feb 9, 2026
github-project-automation
bot
moved this from To Triage
to Ready
in gpt-oss Issues & Enhancements
github-project-automation
bot
moved this from Ready
to Done
in gpt-oss Issues & Enhancements
gshtras
added a commit
to ROCm/vllm
that referenced
this pull request
Feb 10, 2026
… if the new API is not available (vllm-project#34153) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
… if the new API is not available (vllm-project#34153) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
… if the new API is not available (vllm-project#34153) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
liuchenbing2026
pushed a commit
to liuchenbing2026/vllm
that referenced
this pull request
Apr 4, 2026
… if the new API is not available (vllm-project#34153) Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up for #30525
ROCm version of triton_kernels does not have SparseMatrix or make_ragged_tensor_metadata
Until we can move to the updated one, to preserve GPT-OSS support on ROCm, we fall back to the old implementation.
Testing plan
vllm serve openai/gpt-oss-120bshould work