[CI][AMD]Bugfix] Check that model_config is not None in enable_norm_pad_fusion#34007
Merged
tjtanaa merged 3 commits intovllm-project:mainfrom Feb 7, 2026
Merged
Conversation
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a potential AttributeError by adding a None check for cfg.model_config before accessing its attributes. This prevents a crash when model_config is not available. I have one suggestion to make the logic more robust by checking the model type directly instead of relying on a hardcoded hidden size, which will improve maintainability.
5 tasks
tjtanaa
approved these changes
Feb 6, 2026
ProExpertProg
approved these changes
Feb 6, 2026
yewentao256
approved these changes
Feb 6, 2026
Member
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…ad_fusion (vllm-project#34007) Signed-off-by: Randall Smith <Randall.Smith@amd.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
…ad_fusion (vllm-project#34007) Signed-off-by: Randall Smith <Randall.Smith@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
If
cfg.model_configisNone, thenvllm.enable_norm_pad_fusionwill crash. This is causing the following failures in CI:Test Plan
pytest -sv kernels/moeTest Result
1950 passed, 5399 skipped, 8 warningsEssential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.