Revert "[Attention][FA3] Update FA3 to include new swizzle optimization"#33841
Merged
Revert "[Attention][FA3] Update FA3 to include new swizzle optimization"#33841
Conversation
ProExpertProg
requested review from
LucasWilkinson and
pavanimajety
as code owners
ProExpertProg
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that introduced a swizzle optimization in FA3, which was identified as a potential cause for test failures. The revert includes changing the GIT_TAG for the flash-attention dependency back to a previous commit and restoring the scheduler_metadata size calculation in flash_attn.py and flashattn_mla.py. The changes are a clean and necessary revert to address the correctness issues. The code looks good.
3 tasks
ProExpertProg
changed the title
Collaborator
Author
|
Plausible fix in #33854 |
ProExpertProg
changed the title
LucasWilkinson
approved these changes
Feb 5, 2026
Collaborator
Author
|
#33854 sadly does not fix the test, moving forward with this revert |
RegularJoe-CEO
pushed a commit
to RegularJoe-CEO/vllm
that referenced
this pull request
Feb 5, 2026
…on" (vllm-project#33841) Signed-off-by: Eric Waller <e@ewaller.com>
3 tasks
LucasWilkinson
added a commit
to neuralmagic/vllm
that referenced
this pull request
Feb 7, 2026
…ion" (vllm-project#33841) This reverts commit e3bf79f.
LucasWilkinson
added a commit
to neuralmagic/vllm
that referenced
this pull request
Feb 8, 2026
…ion" (vllm-project#33841) This reverts commit e3bf79f.
LucasWilkinson
added a commit
to neuralmagic/vllm
that referenced
this pull request
Feb 10, 2026
…ion" (vllm-project#33841) This reverts commit e3bf79f.
LucasWilkinson
added a commit
to neuralmagic/vllm
that referenced
this pull request
Feb 11, 2026
…ion" (vllm-project#33841) This reverts commit e3bf79f. Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #23465
As described in #33802, #23465 broke the Distributed Tests 2 GPUs (H100).
Note that since the tests have been slightly refactored so the failing test (
test_async_tp.py::test_async_pass_correctness) is now in a new group after #33293. The full CI run for that PR is here:This PR gets both the new tests green (old were already green above).