[Misc] Delay deprecation of CommonAttentionMetadata properties#33801
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Feb 4, 2026
Merged
[Misc] Delay deprecation of CommonAttentionMetadata properties#33801vllm-bot merged 1 commit intovllm-project:mainfrom
vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
LucasWilkinson
requested review from
WoosukKwon,
alexm-redhat,
njhill,
youkaichao and
zhuohan123
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the deprecation messages for the seq_lens_cpu and num_computed_tokens_cpu properties in CommonAttentionMetadata. The change removes the specific version v0.15.0 targeted for removal and replaces it with a more general message urging users to migrate. This aligns with the pull request's goal of delaying the deprecation due to performance and stability concerns. The changes are correct and look good.
mgoin
approved these changes
Feb 4, 2026
github-actions
bot
added
the
ready
gameofdimension
pushed a commit
to gameofdimension/vllm
that referenced
this pull request
Feb 5, 2026
…project#33801) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…project#33801) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
…project#33801) Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecation is delayed due to snags with performance #33771 and CI instability slowing down #32073
Remove version for now until the timeline becomes more clear