Merged
Conversation
Signed-off-by: Zachary Aristei <zaristei@nvidia.com> Co-authored-by: Zachary Aristei <zaristei@nvidia.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the aiohttp dependency across several requirement files. However, the specified versions (3.13.0 and 3.13.3) do not appear to be valid, publicly released versions of aiohttp. This is a critical issue that will break the dependency installation process. I've suggested correcting these to 3.9.3, which seems to be the version intended by the original PR #33621 to address a security vulnerability. Please verify and update to a valid version.
tjtanaa
approved these changes
Feb 4, 2026
gameofdimension
pushed a commit
to gameofdimension/vllm
that referenced
this pull request
Feb 5, 2026
Signed-off-by: Zachary Aristei <zaristei@nvidia.com> Co-authored-by: zaristei2 <zaristei2@gmail.com> Co-authored-by: Zachary Aristei <zaristei@nvidia.com> Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
Contributor
|
This PR is causing build errors in vllm:latest dockers. !! |
1 task
amd-hhashemi
added a commit
to amd-hhashemi/vllm
that referenced
this pull request
Feb 9, 2026
This reverts commit 32a02c7.
amd-hhashemi
added a commit
to amd-hhashemi/vllm
that referenced
this pull request
Feb 9, 2026
This reverts commit 32a02c7. Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Zachary Aristei <zaristei@nvidia.com> Co-authored-by: zaristei2 <zaristei2@gmail.com> Co-authored-by: Zachary Aristei <zaristei@nvidia.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
Signed-off-by: Zachary Aristei <zaristei@nvidia.com> Co-authored-by: zaristei2 <zaristei2@gmail.com> Co-authored-by: Zachary Aristei <zaristei@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
#33621 only targeted release branch, we should apply it to main as well.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.