Skip to content

[CI][AMD][BugFix][P/D] Add default_vllm_config to test_moriio_connector.py so tests pass #33739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 17 commits into from
Feb 20, 2026
Merged

[CI][AMD][BugFix][P/D] Add default_vllm_config to test_moriio_connector.py so tests pass #33739

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bf6924c
add default_vllm_config so tests pass
rasmith Feb 3, 2026
dcf1639
use set_current_vllm_config
rasmith Feb 3, 2026
df6bff9
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 7, 2026
04c3906
Merge branch 'vllm-project:main' into rasmith_fix_moriio_test
rasmith Feb 9, 2026
0bb0028
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 9, 2026
0fb271d
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 10, 2026
4f1bd16
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 11, 2026
b3007f1
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 11, 2026
8a78447
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 11, 2026
89a9ff9
move the with statement up
rasmith Feb 18, 2026
794f0f3
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 18, 2026
ead9be7
just put the connector creation in the with
rasmith Feb 18, 2026
79e2bed
Merge branch 'rasmith_fix_moriio_test' of github.com:rasmith/vllm int…
rasmith Feb 18, 2026
b92b237
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 19, 2026
afeb6a5
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 19, 2026
3288639
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 19, 2026
05b0279
Merge branch 'main' into rasmith_fix_moriio_test
rasmith Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions tests/v1/kv_connector/unit/test_moriio_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
ModelConfig,
SchedulerConfig,
VllmConfig,
set_current_vllm_config,
)
from vllm.distributed.kv_transfer.kv_connector.v1.moriio.moriio_common import (
MoRIIOAgentMetadata,
Expand Down Expand Up @@ -433,10 +434,11 @@ def test_register_kv_caches(mock_parallel_groups):
}
)

connector = MoRIIOConnector(vllm_config, KVConnectorRole.WORKER)
connector.connector_worker = FakeMorIIOConnectorWorker(
vllm_config, connector.engine_id, hand_shake_latency=0
)
with set_current_vllm_config(vllm_config):
Copy link
Contributor

@inkcherry inkcherry Feb 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM.
Issue introduced by #30531 and #29575.
Noted related PR we can refer to : #31747, nixl also uses a similar approach
line: https://github.com/vllm-project/vllm/pull/31747/changes#diff-6ec47a6ca238ea4d626f7c5a87ab146a486dc61d5c4b024ef494622b5bf33636R312

connector = MoRIIOConnector(vllm_config, KVConnectorRole.WORKER)
connector.connector_worker = FakeMorIIOConnectorWorker(
vllm_config, connector.engine_id, hand_shake_latency=0
)

from mori.io import (
MemoryDesc,
Expand Down Expand Up @@ -523,7 +525,8 @@ def test_moriio_handshake_returns_metadata(mock_parallel_groups):
"handshake_port": handshake_port,
}
)
connector = MoRIIOConnector(vllm_config, KVConnectorRole.WORKER)
with set_current_vllm_config(vllm_config):
connector = MoRIIOConnector(vllm_config, KVConnectorRole.WORKER)

# Execute register_kv_caches
connector.register_kv_caches(kv_caches)
Expand Down