-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[CI][AMD][BugFix][P/D] Add default_vllm_config to test_moriio_connector.py so tests pass #33739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
bf6924c
add default_vllm_config so tests pass
rasmith dcf1639
use set_current_vllm_config
rasmith df6bff9
Merge branch 'main' into rasmith_fix_moriio_test
rasmith 04c3906
Merge branch 'vllm-project:main' into rasmith_fix_moriio_test
rasmith 0bb0028
Merge branch 'main' into rasmith_fix_moriio_test
rasmith 0fb271d
Merge branch 'main' into rasmith_fix_moriio_test
rasmith 4f1bd16
Merge branch 'main' into rasmith_fix_moriio_test
rasmith b3007f1
Merge branch 'main' into rasmith_fix_moriio_test
rasmith 8a78447
Merge branch 'main' into rasmith_fix_moriio_test
rasmith 89a9ff9
move the with statement up
rasmith 794f0f3
Merge branch 'main' into rasmith_fix_moriio_test
rasmith ead9be7
just put the connector creation in the with
rasmith 79e2bed
Merge branch 'rasmith_fix_moriio_test' of github.com:rasmith/vllm int…
rasmith b92b237
Merge branch 'main' into rasmith_fix_moriio_test
rasmith afeb6a5
Merge branch 'main' into rasmith_fix_moriio_test
rasmith 3288639
Merge branch 'main' into rasmith_fix_moriio_test
rasmith 05b0279
Merge branch 'main' into rasmith_fix_moriio_test
rasmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, LGTM.
Issue introduced by #30531 and #29575.
Noted related PR we can refer to : #31747, nixl also uses a similar approach
line: https://github.com/vllm-project/vllm/pull/31747/changes#diff-6ec47a6ca238ea4d626f7c5a87ab146a486dc61d5c4b024ef494622b5bf33636R312