Skip to content

[Bugfix][ROCm] Include float8_e4m3fnuz in NCCL Dtype Dispatching #33713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vllm-bot merged 3 commits into from
Feb 4, 2026
Merged

[Bugfix][ROCm] Include float8_e4m3fnuz in NCCL Dtype Dispatching #33713

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
094234c
add fp8_e4m3fnuz in nccl dtype dispatching
micah-wil Feb 3, 2026
a57707c
use current_platform.fp8_dtype()
micah-wil Feb 3, 2026
915bcca
Merge branch 'main' into micah/nccl-dtype
micah-wil Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/distributed/device_communicators/pynccl_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def from_torch(cls, dtype: torch.dtype) -> int:
return cls.ncclFloat64
if dtype == torch.bfloat16:
return cls.ncclBfloat16
if dtype == torch.float8_e4m3fn:
if dtype in (torch.float8_e4m3fn, torch.float8_e4m3fnuz):
Comment thread
micah-wil marked this conversation as resolved.
Outdated
return cls.ncclFloat8e4m3
raise ValueError(
f"Unsupported dtype {dtype}: should be one of "
Expand Down
Loading