[Hybrid] Enable spec decoding in mamba cache align mode#33705
Merged
heheda12345 merged 11 commits intovllm-project:mainfrom Feb 13, 2026
Merged
[Hybrid] Enable spec decoding in mamba cache align mode#33705heheda12345 merged 11 commits intovllm-project:mainfrom
heheda12345 merged 11 commits intovllm-project:mainfrom
Conversation
Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com>
Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com>
Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com>
Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request re-enables speculative decoding for Mamba models when using the 'align' cache mode. The change primarily consists of removing a check that previously disallowed this combination. A corresponding end-to-end test has also been re-enabled to validate the functionality. The changes are clear, well-targeted, and I have not found any issues.
Closed
5 tasks
Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com>
Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com>
|
Hi @peakcrosser7, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
athrael-soju
pushed a commit
to athrael-soju/vllm
that referenced
this pull request
Feb 14, 2026
…#33705) Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com> Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
athrael-soju
pushed a commit
to athrael-soju/vllm
that referenced
this pull request
Feb 14, 2026
…#33705) Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com> Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
athrael-soju
pushed a commit
to athrael-soju/vllm
that referenced
this pull request
Feb 14, 2026
…#33705) Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com> Signed-off-by: Athrael Soju <athrael.soju@gmail.com>
wzhao18
pushed a commit
to wzhao18/vllm
that referenced
this pull request
Feb 18, 2026
…#33705) Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com> Signed-off-by: wzhao18 <wzhao18.sz@gmail.com>
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
…#33705) Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
ZJY0516
pushed a commit
to ZJY0516/vllm
that referenced
this pull request
Feb 23, 2026
…#33705) Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com> Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
…#33705) Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
…#33705) Signed-off-by: huanghaoyan.hhy <huanghaoyan.hhy@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Re-enabled spec decoding (no async-scheduling): Previously disabled in #30877, speculative decoding is now re-enabled as the related issues have been confirmed as fixed.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.