Fix Gemma3n audio encoder for Transformers v5#33673
Merged
vllm-bot merged 2 commits intovllm-project:mainfrom Feb 3, 2026
Merged
Fix Gemma3n audio encoder for Transformers v5#33673vllm-bot merged 2 commits intovllm-project:mainfrom
vllm-bot merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a compatibility issue with the upcoming Transformers v5 release for the Gemma3n model. The change ensures that the audio_tower continues to return a tuple as expected by the existing code, by explicitly passing return_dict=False. This is a clean and minimal fix that maintains backward compatibility with Transformers v4. The change is correct and well-justified.
hmellor
changed the title
DarkLight1337
approved these changes
Feb 3, 2026
github-actions
bot
added
the
ready
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Pai <416932041@qq.com>
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Pai <416932041@qq.com>
gameofdimension
pushed a commit
to gameofdimension/vllm
that referenced
this pull request
Feb 5, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
huggingface/transformers#42564 updated all the multimodal feature getting methods to return
BaseModelOutputWithPooling(which is adict) by default. This is a welcome change as it standardises these methods across all models in Transformers.However, this caused issues for Gemma3n in vLLM because it instantiates the
audio_towerusingfrom_config(therefore using theforwardmethod from Transformers) and expects it to return a tuple.This PR handles the output of
audio_tower.forwarddifferently depending on if it is atuple.