Skip to content

[Models] Intern-S1-Pro - #33636

Merged
vllm-bot merged 27 commits into
vllm-project:mainfrom
CUHKSZzxy:support-interns1-pro
Feb 3, 2026
Merged

[Models] Intern-S1-Pro#33636
vllm-bot merged 27 commits into
vllm-project:mainfrom
CUHKSZzxy:support-interns1-pro

Conversation

@CUHKSZzxy

@CUHKSZzxy CUHKSZzxy commented Feb 3, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

Purpose

Intern-S1-Pro model support.

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

CUHKSZzxy and others added 19 commits January 6, 2026 16:44
@CUHKSZzxy
support interns1 pro
94a7c5c 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
better weight loading
6aa82db 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
better inv freq calc location
668455a 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
Merge branch 'main' into support-interns1-pro
767bb81
@CUHKSZzxy
adapt to new name
69171b1 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
minor
ced6964 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
tiny cleanups
44ef618 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
minor
56ea680 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
minor
86c301a 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
support group router
01d312c 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
Merge branch 'main' into support-interns1-pro
94de2be
@CUHKSZzxy
fix merge bug, rename
f734337 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
refactor
42d2f3b 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
fix gate quant error
3d91fbe 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
fix visual quant error
bc4f145 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@Isotr0py
clean fope code
44cfb07 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@CUHKSZzxy
remove unnecessary get config
56ec596 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@Isotr0py
fix video example
5fdad3b 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@CUHKSZzxy
add docs
95f9f43 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
@CUHKSZzxy
CUHKSZzxy requested a review from sighingnow as a code owner February 3, 2026 03:06
@github-actions

github-actions Bot commented Feb 3, 2026

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify

mergify Bot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Documentation preview: https://vllm--33636.org.readthedocs.build/en/33636/

@mergify mergify Bot added documentation Improvements or additions to documentation new-model Requests to new models qwen Related to Qwen models labels Feb 3, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 3, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the Intern-S1-Pro model, a vision-language model that utilizes Mixture-of-Experts (MoE) and Fourier Positional Encoding (FoPE). The changes are well-structured, adding the new model implementation, a FoPE rotary embedding layer, and updating the model registry and examples. The implementation effectively reuses existing components from Qwen models. However, I've identified a critical issue in the new FoPE implementation that needs to be addressed to ensure correct model behavior.

Comment thread vllm/model_executor/layers/rotary_embedding/fope.py
@CUHKSZzxy
change example model name
72a2e8c 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
Isotr0py
Isotr0py reviewed Feb 3, 2026
View reviewed changes
Comment thread vllm/model_executor/models/registry.py
@Isotr0py
update registry
ce85d10 
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
@CUHKSZzxy
explicit kwargs
633d0d4 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
DarkLight1337
DarkLight1337 reviewed Feb 3, 2026
View reviewed changes
Comment thread vllm/model_executor/layers/rotary_embedding/fope.py
@CUHKSZzxy
explicit kwargs in fope
855dee7 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
DarkLight1337
DarkLight1337 approved these changes Feb 3, 2026
View reviewed changes

@DarkLight1337 DarkLight1337 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM now

@DarkLight1337

DarkLight1337 commented Feb 3, 2026

Copy link
Copy Markdown
Member

Can you merge from main to fix CI failures?

@Isotr0py
Isotr0py enabled auto-merge (squash) February 3, 2026 07:19
DarkLight1337
DarkLight1337 reviewed Feb 3, 2026
View reviewed changes
Comment thread tests/models/registry.py
auto-merge was automatically disabled February 3, 2026 08:34

Head branch was pushed to by a user without write access

DarkLight1337
DarkLight1337 reviewed Feb 3, 2026
View reviewed changes
Comment thread tests/models/registry.py Outdated
@DarkLight1337
DarkLight1337 enabled auto-merge (squash) February 3, 2026 08:43
@vllm-bot
vllm-bot merged commit a3acfa1 into vllm-project:main Feb 3, 2026
50 of 52 checks passed
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
@CUHKSZzxy @Isotr0py @PiratePai
[Models] Intern-S1-Pro (vllm-project#33636)
0f6543b 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Pai <416932041@qq.com>
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
@CUHKSZzxy @Isotr0py @PiratePai
[Models] Intern-S1-Pro (vllm-project#33636)
48cbc6f 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: Pai <416932041@qq.com>
gameofdimension pushed a commit to gameofdimension/vllm that referenced this pull request Feb 5, 2026
@CUHKSZzxy @Isotr0py felix01.yu
[Models] Intern-S1-Pro (vllm-project#33636)
fad0fd5 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
@CUHKSZzxy @Isotr0py
[Models] Intern-S1-Pro (vllm-project#33636)
1a77757 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
@CUHKSZzxy @Isotr0py
[Models] Intern-S1-Pro (vllm-project#33636)
05638ea 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
@CUHKSZzxy @Isotr0py
[Models] Intern-S1-Pro (vllm-project#33636)
58ade02 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
@CUHKSZzxy @Isotr0py
[Models] Intern-S1-Pro (vllm-project#33636)
8c87609 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
@CUHKSZzxy @Isotr0py
[Models] Intern-S1-Pro (vllm-project#33636)
4be540c 
Signed-off-by: zxy <zhou0493@e.ntu.edu.sg>
Signed-off-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Co-authored-by: Isotr0py <mozf@mail2.sysu.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes
@Isotr0py Isotr0py Isotr0py approved these changes
@sighingnow sighingnow Awaiting requested review from sighingnow sighingnow is a code owner
@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation new-model Requests to new models qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CUHKSZzxy @DarkLight1337 @Isotr0py @vllm-bot