[Bugfix] Disable RoutingMethodType.[Renormalize,RenormalizeNaive] for TRTLLM per-tensor FP8 MoE#33620
Merged
robertgshaw2-redhat merged 1 commit intovllm-project:mainfrom Feb 3, 2026
Conversation
per-tensor FP8 MoE Signed-off-by: mgoin <mgoin64@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the Renormalize and RenormalizeNaive routing methods for TRT-LLM per-tensor FP8 MoE by commenting them out. This is a temporary measure to address accuracy issues as noted in the associated issue. The change is clear, well-commented, and appears to be a reasonable and safe approach to mitigate the bug. I have no further recommendations.
robertgshaw2-redhat
approved these changes
Feb 3, 2026
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
…LLM per-tensor FP8 MoE (vllm-project#33620) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Pai <416932041@qq.com>
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
…LLM per-tensor FP8 MoE (vllm-project#33620) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: Pai <416932041@qq.com>
gameofdimension
pushed a commit
to gameofdimension/vllm
that referenced
this pull request
Feb 5, 2026
…LLM per-tensor FP8 MoE (vllm-project#33620) Signed-off-by: mgoin <mgoin64@gmail.com> Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…LLM per-tensor FP8 MoE (vllm-project#33620) Signed-off-by: mgoin <mgoin64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
FIX #33532
Test Plan
Test Result
Tested on B200
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.