Skip to content

[Release] Fix format and cherry-pick#33618

Merged
khluu merged 1 commit intovllm-project:releases/v0.15.1from
zhewenl:fix/ruff_and_cherrypick
Feb 3, 2026
Merged

[Release] Fix format and cherry-pick#33618
khluu merged 1 commit intovllm-project:releases/v0.15.1from
zhewenl:fix/ruff_and_cherrypick

Conversation

@zhewenl
Copy link
Copy Markdown
Collaborator

@zhewenl zhewenl commented Feb 3, 2026

pre-commit is failing with ruff format, and:

vllm/model_executor/layers/quantization/utils/nvfp4_moe_support.py:7: error: Module "vllm.model_executor.layers.quantization.utils.flashinfer_fp4_moe" has no attribute "is_flashinfer_fp4_cutedsl_moe_available"  [attr-defined]
vllm/model_executor/layers/quantization/utils/nvfp4_moe_support.py:7: error: Module "vllm.model_executor.layers.quantization.utils.flashinfer_fp4_moe" has no attribute "is_flashinfer_fp4_cutlass_moe_available"  [attr-defined]
Found 2 errors in 1 file (checked 247 source files)

the reason is cherry-pick has issues to pick up file deletion from https://github.com/vllm-project/vllm/pull/33417/changes#diff-4891f492083262364aca6d94bc2d421c3f95c1e408e7eac6e4c90275d3446480 to 15ebd0c

test with pre-commit:

pre-commit run --all-files
ruff check..........................................................................................Passed
ruff format.........................................................................................Passed
typos...............................................................................................Passed
clang-format........................................................................................Passed
Lint GitHub Actions workflow files..................................................................Passed
pip-compile.........................................................................................Passed
reformat nightly_torch_test.txt to be in sync with test.in..........................................Passed
Run mypy locally for lowest supported Python version................................................Passed
Lint shell scripts..................................................................................Passed
Lint PNG exports from excalidraw....................................................................Passed
Check SPDX headers..................................................................................Passed
Check root lazy imports.............................................................................Passed
Check for spaces in all filenames...................................................................Passed
Update Dockerfile dependency graph..................................................................Passed
Enforce import regex as re..........................................................................Passed
Forbid direct 'import triton'.......................................................................Passed
Prevent new pickle/cloudpickle imports..............................................................Passed
Validate configuration has default values and that each field has a docstring.......................Passed
Validate docker/versions.json matches Dockerfile....................................................Passed
Suggestion..........................................................................................Passed
- hook id: suggestion
- duration: 0s

To bypass all the pre-commit hooks, add --no-verify to git commit. To skip a specific hook, prefix the commit command with SKIP=<hook-id>.

fix
Signed-off-by: zhewenli <zhewen@inferact.ai>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses pre-commit failures. The primary change is the deletion of vllm/model_executor/layers/quantization/utils/nvfp4_moe_support.py, which resolves import errors caused by a previous incomplete cherry-pick. Additionally, an import statement in vllm/model_executor/models/step3p5.py has been reordered to comply with code formatting standards. These changes are appropriate and improve the codebase's integrity. The pull request is ready for merging.

@zhewenl zhewenl force-pushed the fix/ruff_and_cherrypick branch from f9e9966 to 90018e1 Compare February 3, 2026 00:11
@khluu khluu merged commit 31a64c6 into vllm-project:releases/v0.15.1 Feb 3, 2026
4 of 5 checks passed
@zhewenl zhewenl deleted the fix/ruff_and_cherrypick branch February 3, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants