[Release] Fix format and cherry-pick#33618
Merged
khluu merged 1 commit intovllm-project:releases/v0.15.1from Feb 3, 2026
Merged
[Release] Fix format and cherry-pick#33618khluu merged 1 commit intovllm-project:releases/v0.15.1from
khluu merged 1 commit intovllm-project:releases/v0.15.1from
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses pre-commit failures. The primary change is the deletion of vllm/model_executor/layers/quantization/utils/nvfp4_moe_support.py, which resolves import errors caused by a previous incomplete cherry-pick. Additionally, an import statement in vllm/model_executor/models/step3p5.py has been reordered to comply with code formatting standards. These changes are appropriate and improve the codebase's integrity. The pull request is ready for merging.
f9e9966 to
90018e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit is failing with ruff format, and:
the reason is cherry-pick has issues to pick up file deletion from https://github.com/vllm-project/vllm/pull/33417/changes#diff-4891f492083262364aca6d94bc2d421c3f95c1e408e7eac6e4c90275d3446480 to 15ebd0c
test with pre-commit: