[UX] Format attention backend log line - #33570
Merged
ProExpertProg merged 4 commits intoFeb 2, 2026
Merged
Conversation
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the formatting of a log message for the attention backend selection to improve consistency with other log messages in the codebase. The change is minor, replacing tuple-style output with a bracketed list and adding a period. The implementation is correct and achieves the intended cosmetic improvement. The code looks good, and I have no further comments.
ProExpertProg
approved these changes
Feb 2, 2026
ProExpertProg
enabled auto-merge (squash)
February 2, 2026 17:10
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
auto-merge was automatically disabled
February 2, 2026 17:11
Head branch was pushed to by a user without write access
ProExpertProg
enabled auto-merge (squash)
February 2, 2026 17:12
5 tasks
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com> Signed-off-by: Pai <416932041@qq.com>
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com> Signed-off-by: Pai <416932041@qq.com>
gameofdimension
pushed a commit
to gameofdimension/vllm
that referenced
this pull request
Feb 5, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com> Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Clean up attention backend log line to match MoE
Main:
PR:
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.