Skip to content

[UX] Format attention backend log line - #33570

Merged
ProExpertProg merged 4 commits into
vllm-project:mainfrom
MatthewBonanni:backend_list_format
Feb 2, 2026
Merged

ProExpertProg merged 4 commits into
vllm-project:mainfrom
MatthewBonanni:backend_list_format

Conversation

@MatthewBonanni

@MatthewBonanni MatthewBonanni commented Feb 2, 2026

Copy link
Copy Markdown
Member

Purpose

Clean up attention backend log line to match MoE

Main:

(EngineCore_DP0 pid=2126810) INFO 02-02 17:08:08 [cuda.py:364] Using FLASHMLA_SPARSE attention backend out of potential backends: ('FLASHMLA_SPARSE',)
(EngineCore_DP0 pid=2126810) INFO 02-02 17:08:08 [fp8.py:329] Using FLASHINFER_CUTLASS Fp8 MoE backend out of potential backends: ['AITER', 'FLASHINFER_TRTLLM', 'FLASHINFER_CUTLASS', 'DEEPGEMM', 'BATCHED_DEEPGEMM', 'TRITON', 'BATCHED_TRITON', 'MARLIN'].

PR:

(EngineCore_DP0 pid=2133585) INFO 02-02 17:11:37 [cuda.py:364] Using FLASHMLA_SPARSE attention backend out of potential backends: ['FLASHMLA_SPARSE'].
(EngineCore_DP0 pid=2133585) INFO 02-02 17:11:37 [fp8.py:329] Using FLASHINFER_CUTLASS Fp8 MoE backend out of potential backends: ['AITER', 'FLASHINFER_TRTLLM', 'FLASHINFER_CUTLASS', 'DEEPGEMM', 'BATCHED_DEEPGEMM', 'TRITON', 'BATCHED_TRITON', 'MARLIN'].

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the formatting of a log message for the attention backend selection to improve consistency with other log messages in the codebase. The change is minor, replacing tuple-style output with a bracketed list and adding a period. The implementation is correct and achieves the intended cosmetic improvement. The code looks good, and I have no further comments.

@github-project-automation github-project-automation Bot moved this to Ready in NVIDIA Feb 2, 2026
@ProExpertProg
ProExpertProg enabled auto-merge (squash) February 2, 2026 17:10
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 2, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
auto-merge was automatically disabled February 2, 2026 17:11

Head branch was pushed to by a user without write access

@ProExpertProg
ProExpertProg enabled auto-merge (squash) February 2, 2026 17:12
@ProExpertProg
ProExpertProg merged commit 5d1aef3 into vllm-project:main Feb 2, 2026
43 checks passed
@github-project-automation github-project-automation Bot moved this from Ready to Done in NVIDIA Feb 2, 2026
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: Pai <416932041@qq.com>
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: Pai <416932041@qq.com>
gameofdimension pushed a commit to gameofdimension/vllm that referenced this pull request Feb 5, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nvidia ready ONLY add when PR is ready to merge/full CI is needed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants