[Bugfix] Fix incompatibility between #33372 and #32863#33475
Merged
vllm-bot merged 4 commits intovllm-project:mainfrom Jan 31, 2026
Merged
[Bugfix] Fix incompatibility between #33372 and #32863#33475vllm-bot merged 4 commits intovllm-project:mainfrom
vllm-bot merged 4 commits intovllm-project:mainfrom
Conversation
…ect#32863 Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a critical bug where a NameError would occur in several renderers due to an undefined kwargs variable. The fix correctly removes the lines causing the error. Additionally, the logic to set return_dict=False for chat template application has been centralized in vllm/renderers/params.py, which is a good refactoring that improves maintainability. Other related files have been cleaned up for consistency. The changes are correct and effectively resolve the issue.
hmellor
approved these changes
Jan 31, 2026
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
…ect#32863 (vllm-project#33475) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Pai <416932041@qq.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…ect#32863 (vllm-project#33475) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix
kwargsnot defined error because #32863 was merged without considering the changes from #33372.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.