[Bugfix] Fix Sparse24 Compressed Tensors models#33446
Merged
vllm-bot merged 7 commits intovllm-project:mainfrom Feb 12, 2026
Merged
[Bugfix] Fix Sparse24 Compressed Tensors models#33446vllm-bot merged 7 commits intovllm-project:mainfrom
vllm-bot merged 7 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a regression that caused a KeyError when loading sparse24 compressed tensor models. The fix involves adding a check to ensure the config_groups key exists in the configuration dictionary before attempting to process it. This is a correct and necessary change that prevents the crash. The implementation is clear and directly solves the issue. I approve these changes.
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Contributor
Author
Member
|
Can we just remove 24 sparsity instead? |
mgoin
approved these changes
Feb 9, 2026
warichet
pushed a commit
to warichet/vllm
that referenced
this pull request
Feb 12, 2026
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
eldarkurtic
pushed a commit
to eldarkurtic/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> Co-authored-by: Michael Goin <mgoin64@gmail.com> Signed-off-by: Eldar Kurtic <research@neuralmagic.com>
llsj14
pushed a commit
to llsj14/vllm
that referenced
this pull request
Mar 1, 2026
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
tunglinwood
pushed a commit
to tunglinwood/vllm
that referenced
this pull request
Mar 4, 2026
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Background
#30141 introduced a check against
config_groupsin the compressed tensors config. However, theconfig_groupsfield is not populated in the case of sparse24 models.This regression should have been caught by
tests/quantization/test_compressed_tensors.py::test_compressed_tensors_2of4_sparse, however this test is skipped by the CI because the CI runs with CC<90. A broader discussion should be had as to whether quantization tests should be run with higher CC, likely accompanied with a pruning of existing quantization tests.Changes
config_groupsfield before filtering out Attention groupsTesting
test_compressed_tensors_2of4_sparseandtest_compressed_tensors_2of4_sparse_compressedpreviously failed but now passes on hopper machinenm-testing/TinyLlama-1.1B-Chat-v1.0-sparse2of4_only-e2eon hopper machine