fix QERL attention import path#33432
Merged
vllm-bot merged 2 commits intovllm-project:mainfrom Jan 30, 2026
Merged
Conversation
Summary: vllm-project#32133 missed a rebase on vllm-project#32064, fixing the attention path import Test Plan: ```bash // before this PR, the test runner failed because the old attention // import path no longer exists pytest tests/quantization/test_fp8.py -s -x ``` Reviewers: Subscribers: Tasks: Tags: Signed-off-by: vasiliy <vasiliy@fb.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes the import path for Attention and MLAAttention in vllm/model_executor/model_loader/reload/layerwise.py. This change is a necessary fix following a recent refactoring where attention-related modules were moved. The updated import paths are correct and resolve the issue described. The change is straightforward and looks good.
ProExpertProg
approved these changes
Jan 30, 2026
github-actions
bot
added
the
ready
mgoin
reviewed
Jan 30, 2026
Signed-off-by: Michael Goin <mgoin64@gmail.com>
5 tasks
5 tasks
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: vasiliy <vasiliy@fb.com> Signed-off-by: Michael Goin <mgoin64@gmail.com> Co-authored-by: Michael Goin <mgoin64@gmail.com> Signed-off-by: Pai <416932041@qq.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: vasiliy <vasiliy@fb.com> Signed-off-by: Michael Goin <mgoin64@gmail.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
#32133 missed a rebase on #32064, fixing the attention path import
Test Plan:
// before this PR, the test runner failed because the old attention // import path no longer exists pytest tests/quantization/test_fp8.py -s -xReviewers:
Subscribers:
Tasks:
Tags:
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.