Skip to content

move spec decode slow test to test_areas.yaml - #33365

Merged
vllm-bot merged 1 commit into
vllm-project:mainfrom
neuralmagic:spec-decode-slow-test
Feb 2, 2026
Merged

vllm-bot merged 1 commit into
vllm-project:mainfrom
neuralmagic:spec-decode-slow-test

Conversation

@shanjiaz

@shanjiaz shanjiaz commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Purpose

Moved spec decode sloe test to test_areas.yaml. Added test was previously approved in a former PR.

Test Plan

Tested the command locally.
pytest tests/v1/spec_decode/test_acceptance_length.py -m 'slow_test'

Test Result

============================================================ test session starts =============================================================
platform linux -- Python 3.12.11, pytest-9.0.2, pluggy-1.6.0
rootdir: /home/shanjiaz/nm-vllm/vllm
configfile: pyproject.toml
plugins: anyio-4.12.1
collected 12 items / 9 deselected / 3 selected                                                                                                                                                

tests/v1/spec_decode/test_acceptance_length.py ...                                                                                                                                      [100%]

====================================================================================== warnings summary =======================================================================================
<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyPacked has no __module__ attribute

<frozen importlib._bootstrap>:488
  <frozen importlib._bootstrap>:488: DeprecationWarning: builtin type SwigPyObject has no __module__ attribute

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=================================================================== 3 passed, 9 deselected, 2 warnings in 448.49s (0:07:28) ==================

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully moves a slow speculative decoding test to a separate Buildkite step, which will improve CI performance for the main test suite. The changes in .buildkite/test_areas/misc.yaml correctly exclude the slow test from the general test run and add a new, dedicated step to execute it. The test itself is appropriately marked. The changes are clean and achieve the intended purpose. I have no major concerns.

@mgoin mgoin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's see if I can trigger in CI

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 29, 2026
@vllm-bot
vllm-bot merged commit d95b4be into vllm-project:main Feb 2, 2026
18 of 24 checks passed
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
Signed-off-by: Pai <416932041@qq.com>
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
Signed-off-by: Pai <416932041@qq.com>
gameofdimension pushed a commit to gameofdimension/vllm that referenced this pull request Feb 5, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed speculative-decoding v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants