move spec decode slow test to test_areas.yaml - #33365
Merged
Merged
Conversation
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully moves a slow speculative decoding test to a separate Buildkite step, which will improve CI performance for the main test suite. The changes in .buildkite/test_areas/misc.yaml correctly exclude the slow test from the general test run and add a new, dedicated step to execute it. The test itself is appropriately marked. The changes are clean and achieve the intended purpose. I have no major concerns.
mgoin
approved these changes
Jan 29, 2026
mgoin
left a comment
Member
There was a problem hiding this comment.
LGTM let's see if I can trigger in CI
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com> Signed-off-by: Pai <416932041@qq.com>
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com> Signed-off-by: Pai <416932041@qq.com>
gameofdimension
pushed a commit
to gameofdimension/vllm
that referenced
this pull request
Feb 5, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com> Signed-off-by: felix01.yu <felix01.yu@vipshop.com>
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Moved spec decode sloe test to
test_areas.yaml. Added test was previously approved in a former PR.Test Plan
Tested the command locally.
pytest tests/v1/spec_decode/test_acceptance_length.py -m 'slow_test'Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.