[BugFix] Fix whisper FA2 + full cudagraphs#33360
Merged
DarkLight1337 merged 4 commits intovllm-project:mainfrom Jan 31, 2026
Merged
[BugFix] Fix whisper FA2 + full cudagraphs#33360DarkLight1337 merged 4 commits intovllm-project:mainfrom
DarkLight1337 merged 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes an issue with CUDA graph capture for encoder-decoder models using FlashAttention 2 by ensuring a non-zero max_seq_len is used during graph creation. The approach of setting a realistic encoder length during capture is correct. I've identified one area for improvement in the fallback logic for determining this length to make the fix more robust.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Lucas Wilkinson <LucasWilkinson@users.noreply.github.com>
NickLucche
approved these changes
Jan 29, 2026
Collaborator
NickLucche
left a comment
There was a problem hiding this comment.
Thank you! If CI is green this should be good as we have FA2 machines :)
|
Hi @LucasWilkinson, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
khluu
pushed a commit
that referenced
this pull request
Feb 2, 2026
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: Lucas Wilkinson <LucasWilkinson@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Michael Goin <mgoin64@gmail.com> (cherry picked from commit 0a3c71e)
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: Lucas Wilkinson <LucasWilkinson@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Michael Goin <mgoin64@gmail.com> Signed-off-by: Pai <416932041@qq.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com> Signed-off-by: Lucas Wilkinson <LucasWilkinson@users.noreply.github.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Michael Goin <mgoin64@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #33091
CrossAttentionBuilder.build()overridesmax_seq_lenwith encoder_seq_lens (new_metadata.max_seq_len = max(encoder_seq_lens_cpu)) this leads to a CG capture withmax_seq_len == 0and an incorrect graph