[Bugfix] Fix Qwen3-VL-Reranker load.#33298
Conversation
|
Documentation preview: https://vllm--33298.org.readthedocs.build/en/33298/ |
There was a problem hiding this comment.
Code Review
This pull request fixes an issue with loading the Qwen3-VL-Reranker model by adjusting the weight loading logic for sequence classification models, specifically for Vision Language Models (VLMs). The core change introduces a more specific check (using_vlm_head) to correctly identify where the score layer is located in VLMs.
Additionally, the PR refactors the encode_base64_content_from_url utility function into a new vllm.utils.mm_utils module and updates example scripts and tests to use it. This centralization is a good improvement.
My review focuses on a potential issue in the newly introduced utility function. I've suggested a change to make it more robust by dynamically handling image content types and using appropriate headers for GET requests. The rest of the changes, including the main bugfix and the addition of tests, look solid.
|
Hi @noooop, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: wang.yuqi <noooop@126.com>
|
Hi @noooop, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
Hi @noooop, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> (cherry picked from commit abb34ac)
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: PiratePai <416932041@qq.com> Signed-off-by: Pai <416932041@qq.com>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: wang.yuqi <noooop@126.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Purpose
Fix Qwen3-VL-Reranker load.
Test Plan
tests/entrypoints/pooling/score/test_online_score_vision.py
Test Result
pass
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.