Skip to content

[Bugfix] Fix Qwen3-VL-Reranker load.#33298

Merged
DarkLight1337 merged 10 commits intovllm-project:mainfrom
noooop:fix_qwen_vl
Jan 29, 2026
Merged

[Bugfix] Fix Qwen3-VL-Reranker load.#33298
DarkLight1337 merged 10 commits intovllm-project:mainfrom
noooop:fix_qwen_vl

Conversation

@noooop
Copy link
Copy Markdown
Collaborator

@noooop noooop commented Jan 29, 2026

Purpose

Fix Qwen3-VL-Reranker load.

Test Plan

tests/entrypoints/pooling/score/test_online_score_vision.py

Test Result

pass


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify
Copy link
Copy Markdown

mergify bot commented Jan 29, 2026

Documentation preview: https://vllm--33298.org.readthedocs.build/en/33298/

@mergify mergify bot added documentation Improvements or additions to documentation qwen Related to Qwen models bug Something isn't working labels Jan 29, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue with loading the Qwen3-VL-Reranker model by adjusting the weight loading logic for sequence classification models, specifically for Vision Language Models (VLMs). The core change introduces a more specific check (using_vlm_head) to correctly identify where the score layer is located in VLMs.

Additionally, the PR refactors the encode_base64_content_from_url utility function into a new vllm.utils.mm_utils module and updates example scripts and tests to use it. This centralization is a good improvement.

My review focuses on a potential issue in the newly introduced utility function. I've suggested a change to make it more robust by dynamically handling image content types and using appropriate headers for GET requests. The rest of the changes, including the main bugfix and the addition of tests, look solid.

@mergify
Copy link
Copy Markdown

mergify bot commented Jan 29, 2026

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: wang.yuqi <noooop@126.com>
@mergify
Copy link
Copy Markdown

mergify bot commented Jan 29, 2026

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 29, 2026 02:35
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 29, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@mergify
Copy link
Copy Markdown

mergify bot commented Jan 29, 2026

Hi @noooop, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@DarkLight1337 DarkLight1337 merged commit abb34ac into vllm-project:main Jan 29, 2026
52 checks passed
@noooop noooop deleted the fix_qwen_vl branch January 29, 2026 08:43
@khluu khluu added this to the v0.15.1 Hotfix milestone Jan 29, 2026
apd10 pushed a commit to apd10/vllm that referenced this pull request Jan 31, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
khluu pushed a commit that referenced this pull request Feb 2, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
(cherry picked from commit abb34ac)
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: PiratePai <416932041@qq.com>
Signed-off-by: Pai <416932041@qq.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: wang.yuqi <noooop@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants