Skip to content

[Bugfix] Fix Hybrid KV cache hit length computation for eagle #33270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xyang16 wants to merge 3 commits into from
Closed

[Bugfix] Fix Hybrid KV cache hit length computation for eagle #33270

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
260be73
[Bugfix] Fix cache hit computation for eagle
xyang16 Jan 27, 2026
40b4f1e
Reuse cached blocks
xyang16 Jan 28, 2026
63e16e4
Add tests
xyang16 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vllm/v1/core/kv_cache_coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,10 @@ def _get_block_hashes(kv_cache_spec: KVCacheSpec) -> BlockHashList:
for group_id, blocks in zip(group_ids, hit_blocks):
hit_blocks_by_group[group_id] = blocks

if curr_hit_length < hit_length:
if self.use_eagle:
hit_length = curr_hit_length
break
Comment thread
xyang16 marked this conversation as resolved.
Outdated
elif curr_hit_length < hit_length:
hit_length = curr_hit_length
else:
break
Comment thread
xyang16 marked this conversation as resolved.
Outdated
Expand Down