Relax protobuf library version constraints#33202
Merged
njhill merged 1 commit intovllm-project:mainfrom Jan 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly refactors the grpc-server dependencies into an optional extra requirement, which can be installed via pip install vllm[grpc-server]. This is achieved by moving the protobuf version constraint from requirements/common.txt to a new grpc-server extra in setup.py. A runtime check has been added to grpc_server.py to ensure the required protobuf version is installed, providing a clear error message if it's not. The implementation is clean and effective. I've added one high-severity comment to improve the robustness of the version check by handling a potential AttributeError.
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
c859445 to
d281280
Compare
Contributor
Author
eicherseiji
approved these changes
Jan 28, 2026
Contributor
eicherseiji
left a comment
There was a problem hiding this comment.
Thanks @jeffreywang-anyscale and @njhill!
njhill
approved these changes
Jan 28, 2026
VedantMadane
pushed a commit
to VedantMadane/vllm
that referenced
this pull request
Jan 28, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com> Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
khluu
pushed a commit
that referenced
this pull request
Jan 28, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com> (cherry picked from commit a97b5e2)
apd10
pushed a commit
to apd10/vllm
that referenced
this pull request
Jan 31, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
PiratePai
pushed a commit
to PiratePai/epd_shm
that referenced
this pull request
Feb 3, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com> Signed-off-by: Pai <416932041@qq.com>
1 task
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Relaxes the strict version pins for protobuf, grpcio, and grpcio-reflection introduced in #30190 (gRPC server entrypoint). This allows vLLM to work with a wider range of protobuf versions while maintaining compatibility.
Ray is upgrading vLLM to 0.14.0, but there are other dependencies in Ray conflicting with the protobuf version that vLLM requires (>=6.30.0) starting from the introduction of #30190. It's because that some other libraries that ray depends on require an older version of protobuf. For example with tensorflow, we run into such errors:
Test Plan & Result
Verified that installing common.txt with
uv pip install -r requirements/common.txtin a clean conda environment resolves to the same versions with and without the constraints.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.