Skip to content

Relax protobuf library version constraints#33202

Merged
njhill merged 1 commit intovllm-project:mainfrom
jeffreywang-anyscale:protobuf-optional
Jan 28, 2026
Merged

Relax protobuf library version constraints#33202
njhill merged 1 commit intovllm-project:mainfrom
jeffreywang-anyscale:protobuf-optional

Conversation

@jeffreywang-anyscale
Copy link
Copy Markdown
Contributor

@jeffreywang-anyscale jeffreywang-anyscale commented Jan 27, 2026

Purpose

Relaxes the strict version pins for protobuf, grpcio, and grpcio-reflection introduced in #30190 (gRPC server entrypoint). This allows vLLM to work with a wider range of protobuf versions while maintaining compatibility.

Ray is upgrading vLLM to 0.14.0, but there are other dependencies in Ray conflicting with the protobuf version that vLLM requires (>=6.30.0) starting from the introduction of #30190. It's because that some other libraries that ray depends on require an older version of protobuf. For example with tensorflow, we run into such errors:

tensorflow 2.15.1 depends on protobuf!=4.21.0, !=4.21.1, !=4.21.2, !=4.21.3, !=4.21.4, !=4.21.5, <5.0.0dev and >=3.20.3

Test Plan & Result

Verified that installing common.txt with uv pip install -r requirements/common.txt in a clean conda environment resolves to the same versions with and without the constraints.

  • With
protobuf==6.33.4
grpcio==1.76.0
  • Without
protobuf==6.33.4
grpcio==1.76.0

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly refactors the grpc-server dependencies into an optional extra requirement, which can be installed via pip install vllm[grpc-server]. This is achieved by moving the protobuf version constraint from requirements/common.txt to a new grpc-server extra in setup.py. A runtime check has been added to grpc_server.py to ensure the required protobuf version is installed, providing a clear error message if it's not. The implementation is clean and effective. I've added one high-severity comment to improve the robustness of the version check by handling a potential AttributeError.

Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
@jeffreywang-anyscale jeffreywang-anyscale changed the title Bundling grpc-server dependencies as extra requirements Relax protobuf library version constraints Jan 28, 2026
@jeffreywang-anyscale jeffreywang-anyscale marked this pull request as ready for review January 28, 2026 00:46
@jeffreywang-anyscale
Copy link
Copy Markdown
Contributor Author

cc: @njhill @eicherseiji @kouroshHakha

@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 28, 2026
Copy link
Copy Markdown
Contributor

@eicherseiji eicherseiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njhill njhill enabled auto-merge (squash) January 28, 2026 03:47
@njhill njhill merged commit a97b5e2 into vllm-project:main Jan 28, 2026
106 checks passed
VedantMadane pushed a commit to VedantMadane/vllm that referenced this pull request Jan 28, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
khluu pushed a commit that referenced this pull request Jan 28, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
(cherry picked from commit a97b5e2)
apd10 pushed a commit to apd10/vllm that referenced this pull request Jan 31, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
PiratePai pushed a commit to PiratePai/epd_shm that referenced this pull request Feb 3, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
Signed-off-by: Pai <416932041@qq.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: Jeffrey Wang <jeffreywang@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants