[Bugfix] Disable CG for Whisper+FA2#33164
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Jan 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a temporary but effective fix for an accuracy issue observed with FlashAttention2 (FA2) when used with encoder-decoder models, specifically Whisper, as detailed in issue #33091. The change correctly disables CUDA graphs for this specific combination, mitigating the reported accuracy problems. The implementation is clear, uses logger.warning_once for informative logging, and appears to handle edge cases appropriately, such as when FlashAttention is not available or when the global CUDA graph mode is already set. This is a well-targeted solution to a critical accuracy bug.
DarkLight1337
approved these changes
Jan 27, 2026
VedantMadane
pushed a commit
to VedantMadane/vllm
that referenced
this pull request
Jan 28, 2026
Signed-off-by: NickLucche <nlucches@redhat.com> Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
khluu
pushed a commit
that referenced
this pull request
Jan 28, 2026
Signed-off-by: NickLucche <nlucches@redhat.com> (cherry picked from commit 1f3a2c2)
apd10
pushed a commit
to apd10/vllm
that referenced
this pull request
Jan 31, 2026
Signed-off-by: NickLucche <nlucches@redhat.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: NickLucche <nlucches@redhat.com>
khairulkabir1661
pushed a commit
to khairulkabir1661/vllm
that referenced
this pull request
Mar 26, 2026
Signed-off-by: NickLucche <nlucches@redhat.com> (cherry picked from commit 1f3a2c2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary fix to address #33091 for a tentative v0.15.0 release. As the issue is purely in accuracy and does not produce a crash, I believe it's better to patch it until fixed as to not mislead users deploying Whisper.
This PR disables CG for encoder-decoder models when FA2 is detected.
Test with
or with manual script from issue (failing on master):